Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(canvas) remove window event listeners on unmount #628

Merged
merged 1 commit into from Oct 21, 2020
Merged

fix(canvas) remove window event listeners on unmount #628

merged 1 commit into from Oct 21, 2020

Conversation

enidemi
Copy link
Contributor

@enidemi enidemi commented Oct 21, 2020

Problem:
When EditorCanvas is remounted it adds multiple window event listeners.

Fix:
Remove window event listeners on onmount

Commit Details:

  • moved all window event handlers to functions
  • remove them when unmounted

@enidemi enidemi changed the title fix(canvas) remove window event listeners on onmount fix(canvas) remove window event listeners on unmount Oct 21, 2020
@enidemi enidemi merged commit dd6ecf5 into master Oct 21, 2020
@enidemi enidemi deleted the fix/canvas-remove-window-eventlisteners branch October 21, 2020 13:12
Rheeseyb
Rheeseyb reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@Rheeseyb Rheeseyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rheeseyb Rheeseyb Rheeseyb left review comments

@seanparsons seanparsons seanparsons approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@alecmolloy alecmolloy Awaiting requested review from alecmolloy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@enidemi @seanparsons @Rheeseyb @balazsbajorics