Enable tests in CodingStyle directory

[mlocati]

Let's include in the test suite the tests introduced in #4157

[a3020]

Tabs alert :)

[mlocati]

Tabs alert :)

Well, even if it's a good start, we could not only test for tabs: there are a lot of style checks that could be done.
Maybe @KorvinSzanto has already done some tests about coding style checks?

[a3020]

I was referring to this, @mlocati

[aembler]

I would really rather not have tests fail if coding standards aren't met. But the short tag check is good.

[KorvinSzanto]

I swear to god I replied to this thread haha. I think we should do this with csfixer or phpmd. We can just add that as a script in .travis like i did with this project here: https://github.com/buttress/browserslist/blob/master/.travis.yml#L32

I definitely don't think it's worth the cpu to do this ourselves in phpunit so I'd like to update this to use something that is purpose made.

[mlocati]

Well, style handling in view files (mix of php and html) is a nightmare.
I guess that readable view files won't pass coding style checks, and view files that pass coding style checks aren't readable that much (see for instance the mess introduced in view files by php-cs-fixer).
So, we have 2 options:

1. include all the files in the checks -> they won't pass or we'd need messy view files
2. exclude view files from tests -> short tags may and un in view files

[mlocati]

I swear to god I replied to this thread haha

You replied here: #4380

[KorvinSzanto]

@mlocati this is what I have in my scrutinizer branch right now. It only runs on one machine:

$ concrete/vendor/bin/phpcs -p --standard=psr2 --sniffs=Generic.PHP.DisallowShortOpenTagSniff,Generic.WhiteSpace.DisallowTabIndent concrete/src concrete/controllers

This works great with #4419 merged

[mlocati]

My manual and stupid (but effective) check shows a red flag on tests for every php file.

Is this possible with your approach (not limited to controllers or src directories)?

[KorvinSzanto]

Yeah, just use

$ concrete/vendor/bin/phpcs -p --standard=psr2 --sniffs=Generic.PHP.DisallowShortOpenTagSniff,Generic.WhiteSpace.DisallowTabIndent concrete

But there are quite a lot of tab vs space issues in view files and I figured it's not really worth it anyway. IMO better get the classes solid than have overly permissive code style checks.