Improve Express Form controller #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3020
force-pushed
the
improve_express_form_controller
branch
from
72f4463
to
5c23665
Compare
|
If someone could review these commits, I'd be really thankful! |
wordish
reviewed
Oct 12, 2018
| /** | ||
| * @return array [ | ||
| * Key: string, asset type | ||
| * Value: string, the URL of the asset |
There was a problem hiding this comment.
I think this will return Value: array of strings
wordish
reviewed
Oct 12, 2018
aembler
requested changes
Oct 24, 2018
| @@ -514,7 +510,7 @@ public function save($data) | |||
| $key->setAttributeType($type); | |||
| $settings = $control->getAttributeKey()->getAttributeKeySettings(); | |||
| $settings->setAttributeKey($key); | |||
| $settings = $settings->mergeAndPersist($entityManager); | |||
| $settings->mergeAndPersist($entityManager); | |||
There was a problem hiding this comment.
You sure about this change? mergeAndPersist specifically returns a value that is now merged in the entity manager:
$detachedEntity = unserialize($serializedEntity); // some detached entity
$entity = $em->merge($detachedEntity);
Please change this pull request so that it only makes the obvious changes like removing needless facades, actual code styling cleanup, and removing unused imports, etc... Anything else and you might be misunderstanding what the original code does.
There was a problem hiding this comment.
I removed it because $settings isn't used later on in the code (afaik). I'll add it back if that's what you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR:
appcontainer instead of Core facadePage::getCurrentPage()viewmethod to the top, because that's where you'd expect itI consider this as a first round of optimization / code clean up...
Ref #4723