-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack access with advanced permissions - Take 2 #7061
Merged
aembler
merged 6 commits into
concretecms:develop
from
mlocati:fix-stack-permissions-v3
Sep 28, 2018
Merged
Fix stack access with advanced permissions - Take 2 #7061
aembler
merged 6 commits into
concretecms:develop
from
mlocati:fix-stack-permissions-v3
Sep 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorvinSzanto
added
status:under development
and removed
status:under development
labels
Sep 19, 2018
mlocati
force-pushed
the
fix-stack-permissions-v3
branch
from
September 21, 2018 12:35
5e9cf38
to
348e518
Compare
This PR should be ready to be reviewed/merged: the main issue is #7086 |
mlocati
force-pushed
the
fix-stack-permissions-v3
branch
from
September 24, 2018 10:16
1b6e984
to
f8fc035
Compare
I can confirm that everithing works. This pull request is still needed because with it:
Bonus tracks:
I can of course close this PR and open different PRs... |
mlocati
force-pushed
the
fix-stack-permissions-v3
branch
from
September 24, 2018 12:10
f8fc035
to
c9b1dfd
Compare
PS: I applied this PR to one of our production sites and everything seems to work fine. |
mlocati
force-pushed
the
fix-stack-permissions-v3
branch
from
September 25, 2018 14:09
8c7be2c
to
67ed985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pool 😉 request is an alternative to #7029.
Here I'm trying to implement what @aembler suggested.
WARNING it's not yet done, I'm currently facing a big issue, as described below.
Let's assume that we configure the stack with the following page permissions:
if we don't specify these lines, the resulting area permissions are the following ones (the user can't add blocks to the stack):
if we specify these lines, the resulting area permissions are the following ones (the user can add blocks to the stack):
BUT, since the permission "can add block to page" is not implemented, we have this error here:
...which I really don't know how to solve 😢