Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure custom thumbnails have upscaling enabled #7697

Merged

Conversation

Projects
None yet
2 participants
@KorvinSzanto
Copy link
Member

KorvinSzanto commented Apr 2, 2019

When we added upscaling as a configurable part of thumbnail types, we inadvertently changed CustomThumbnail instances to fail to generate thumbnails larger than their source image. That's not necessarily a bad thing but it's a break in backwards compatibility that's better suited for 9.0 and some documentation.

@aembler aembler merged commit b6e137b into concrete5:develop Apr 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.