Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package version number #809

Merged

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Sep 17, 2023

When fetching the translations from translate.concretecms.org, Concrete passes it the package version (this is required in order to fetch the translations for the currently installed package version).

At the moment, the package version is 2.6.0, and because there's a git tag associated to it, in translate.concretecms.org there's the an exact version corresponding to it.

So, translate.concretecms.org provides the translations for version 2.6.0.

But what happens if we have the latest master installed? The translatable strings in the package are newer, but translate.concretecms.org still provides the older ones.

The solution? Define a package version in master that's greater than the latest tag. That way, translate.concretecms.org will provide the strings for the "2 development series" (which comes from master).

@Mesuva
Copy link
Collaborator

Mesuva commented Sep 18, 2023

So does that mean that every time we do a release, I should set the version number to something for the release, then do the release, and immediately after update the package version something greater?

@Mesuva Mesuva merged commit 1a52d62 into concretecms-community-store:master Sep 18, 2023
@mlocati mlocati deleted the upgrade-version-number branch September 18, 2023 09:33
@mlocati
Copy link
Contributor Author

mlocati commented Sep 18, 2023

So does that mean that every time we do a release, I should set the version number to something for the release, then do the release, and immediately after update the package version something greater?

Yep: see #811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants