Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Rate Limit support #22

Closed
wants to merge 2 commits into from

Conversation

mlocati
Copy link
Collaborator

@mlocati mlocati commented Mar 13, 2017

@KorvinSzanto What should I do to add a 3rd party composer library?

In this pull request

  • I updated the composer.json file by adding the required library
  • I updated the package version
  • I included the new composer autoload to the package on_start

Questions:

  1. Should I add the composer.lock file too?
  2. Is this correct to add the new autoload with
    require $this->getPackagePath() . '/vendor/autoload.php';
    ?

@mlocati
Copy link
Collaborator Author

mlocati commented Mar 13, 2017

Just a question for @aembler:

This PR adds IPLib as a composer dependency to CommunityTranslation.

BTW I'm planning to revamp the current blacklist control of concrete5 (see concretecms/concretecms#3149 and concretecms/concretecms#5029), by using the same IPLib.

So, what about adding IPLib to the core right now, instead of adding it to CommunityStore ?

@aembler
Copy link
Member

aembler commented Mar 13, 2017 via email

@mlocati
Copy link
Collaborator Author

mlocati commented Mar 13, 2017

Great!

@mlocati mlocati closed this Mar 13, 2017
@KorvinSzanto
Copy link
Member

@mlocati I'd use __DIR__ . "/vendor/autoload.php"; The rest you're on the right track with. You don't really need the .lock for this project but you can have it if you see a need for it. Ideally the composer.json won't allow any versions that aren't compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants