Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.x minor bug in “Swap” file upload dialog #10729

Closed
jessicadunbar opened this issue Jun 30, 2022 · 0 comments · Fixed by #10868
Closed

9.x minor bug in “Swap” file upload dialog #10729

jessicadunbar opened this issue Jun 30, 2022 · 0 comments · Fixed by #10868
Labels
Bug Priority:Low This would be a nice fix, but it mildly improves things that already work. Enhancement:Level of Effort:1 Easiest enhancements to pull off. Enhancement:Quality of Life:2 Enhancements that will have a moderate to large improvement in quality of life Product Areas:File Manager Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.

Comments

@jessicadunbar
Copy link

Affected Version of Concrete CMS

9.x

Description

Heya. Got some old Concrete 5.x sites and just getting into 9.x on a new one and have run into a minor quirk in the Files manager.

If you use the Manage > Swap menu on a file to replace an image or whatever, the dialog that pops up on the ‘Your Computer’ tab has its contents hidden (opacity 0%). You can drag files into it anyway and click Import and it works, you just don’t see any of the file icons or progress indications obviously.

Looking at the elements it seems like one of the enclosing divs (id=“local”) has the class “tab-pane fade active” but is missing “show” to make it visible. So far I’ve not exactly found in the code where this is supposed to happen 😃
Screen Shot 2022-06-30 at 8 26 17 AM

How to reproduce

  1. Go to the file manager
  2. Choose a file
  3. Click Manage
  4. Click Swap
  5. Choose a different image to upload

Possible Solution

Looking at the elements it seems like one of the enclosing divs (id=“local”) has the class “tab-pane fade active” but is missing “show” to make it visible.

Additional Context

https://forums.concretecms.org/t/9-x-minor-bug-in-swap-file-upload-dialog/3409

@jessicadunbar jessicadunbar added the Type:Bug Existing functionality not performing as expected. label Jun 30, 2022
@aembler aembler added Status:Available Reviewed issue, it’s real, we’d review a pull request. Product Areas:File Manager Bug Priority:Low This would be a nice fix, but it mildly improves things that already work. Enhancement:Level of Effort:1 Easiest enhancements to pull off. Enhancement:Quality of Life:2 Enhancements that will have a moderate to large improvement in quality of life labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Priority:Low This would be a nice fix, but it mildly improves things that already work. Enhancement:Level of Effort:1 Easiest enhancements to pull off. Enhancement:Quality of Life:2 Enhancements that will have a moderate to large improvement in quality of life Product Areas:File Manager Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants