Proposal: Add "Allow multiple select" option to express attribute type

[hissy]

Sometimes I'd like to select multiple entries with express attribute type. Database structure allows multiple select, but attribute controller doesn't allow it.

Here's a package to implement a new attribute type to select multiple express entries.

https://github.com/hissy/addon_multiple_express_entry_selector

It simply extends core express attribute controller but overrides some methods. That's it. Let's add an option!

[aembler]

I think it makes sense to update the express attribute that's in the core and give it an option, allowing for single select or multiple select (kind of like how we do it with topics.) Then we'd have to extend the express entry selector to allow multiple selections.

…

On Mon, Jul 17, 2017 at 8:11 PM, Takuro Hishikawa ***@***.***> wrote: Sometimes I'd like to select multiple entries with express attribute type. Database structure allows multiple select, but attribute controller doesn't allow it. Here's a package to implement a new attribute type select multiple express entries. https://github.com/hissy/addon_multiple_express_entry_selector It simply extends core express attribute controller but overrides some methods. That's it. Let's add an option! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5718>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAgNwRDI4zr585q13ki_NsaON8GvGegEks5sPCJYgaJpZM4OayiV> .

[hissy]

I think we have to change searchIndexFieldDefinition to add the option, but can I do it?

I already changed the definition in my experimental package. see:
https://github.com/hissy/addon_multiple_express_entry_selector/blob/master/attributes/express_multiple/controller.php#L12

[aembler]

Yeah I suspect we would have to change that.

…

On Tue, Jul 18, 2017 at 1:59 PM, Takuro Hishikawa ***@***.***> wrote: I think we have to change searchIndexFieldDefinition to add the option, but can I do it? I already changed the definition in my experimental package. see: https://github.com/hissy/addon_multiple_express_entry_ selector/blob/master/attributes/express_multiple/controller.php#L12 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5718 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAgNwTjQ_wseYZctkin8AYGyjOrvkI-gks5sPRyxgaJpZM4OayiV> .

[MrKarlDilkington]

Now that I've spent more time using Express, and specifically express attributes, I can see multiple express attribute selection being very useful and important for making the most of Express.

[mrdansk]

Are any of you able to provide a bit of assistance with this? I've created a user attribute that uses this addon to create a multi-select express attribute. I am just looking at how to set that attribute from an array passed in via a .csv. For the life of me I can't work this out.

[ahukkanen]

I was also looking for this and noticed it's already kind of a feature in the existing attribute. I just needed to extend the current express controller with quite minimal changes + create the UI, no database changes required.

One thing I noticed is missing from the current database mapping table is to have ordering possibility for the selected values. The selected attributes will always come in the order they were added to the database, i.e. sorted by the entries' primary ID column.

It would be nice if the multi select attribute would also provide ordering possibility. It is many times required for the use cases of the multi-select attributes.

[marcelaerts]

Is this working now?

[BloodyIron]

Can we get this added to mainline c5 please? This addon is abandoned and trying to get it working with c5 8.5.0a2 reports broken package. This really should be a baked-in feature, not one relying on the addon.

It is appreciated that the addon was written, but it looks like the original developer isn't interested in maintaining it. And we already have multiple people, including @MrKarlDilkington , agreeing that this would be very useful to have.

[hissy]

The package works with 8.5.2 as well. I think your directory name is wrong, it should be multiple_express_entry_selector instead of addon_multiple_express_entry_selector .

[BloodyIron]

@hissy ahh thanks! Yeah I didn't realise that, as I just grabbed the zip from github and that's the folder it output. Unsure why the folder is named like that if it's wrong out of the box, HAH!

[hissy]

If I have a chance, I can try to implement it for version 9.

[BloodyIron]

Is 8.6 out of the question? v9 seems so distant in time.

[hissy]

You can use my package while 8.x ;-)

[BloodyIron]

Fair enough lol. Thanks again! :D

[BloodyIron]

So, considering it is uncertain which year v9 will come out, can we please look at getting this functionality baked into an 8.5.5 target? This github issue alone has been open since 2017, I think it's time this gets mainlined.

[BloodyIron]

So I've tried using the Express Multi-Select, and in my dev testing (8.5.4) When I add the multi-select addon manually that @hissy developed, I cannot use Single and Multi-Select attributes on the same Express Object, which is a problem for me.

Example scenario:

First Object, is an Event Location (hotel)

Second Object is an Event Location set of Sub-Sections (multiple meeting rooms, halls, etc)

Second Object is Events

Naturally, the Event Location associates with multiple Sub-Locations in a One-to-Many relationship. That works.

Then I create an Event Location, and two Event Location Sub-Sections. Associate the two Sub-Sections with the test Event Location, and that works.

Then I create the Event Object in such a way that it has two associations:
-Event Object associated with Event Location Object, in (Event) Many-To-One (Location) relationship
-Event Object associated with Event Location Sub-Sections (Event) Many-To-Many (Location Sub-Sections) relationship

Then when I define the Event Object I have Name Attribute, Single Express Select (Location) and Multi Express Select (Location Sub-Sections).

I then make a form with Name Attribute, Single Express Select, and Multi-Express Select.

I can enter the Name for the event, but Single Express Select presents NO options (when I know a location exists) BUT Multi-Express Select does work.

I think the issue is when using a Single Express Select AND Multi-Express Select on the same object, disabling the Single Express Select (and I really do need both to work for many reasons!).

Sorry, bit of a word-ful explanation :/

[BloodyIron]

Hey so I'm still stuck here. If anyone can help me sort out what's going on, that would be appreciated. :)

[BloodyIron]

Would a screenshot of what I'm seeing help? I haven't heard anything back on this. :( Still stuck.

[dimger]

i think the problem here https://github.com/hissy/addon_multiple_express_entry_selector/blob/master/attributes/express_multiple/form.php is the selector that is used on selectize call.
Every input of this type that belongs to the same entity will have the same selector.
So i would recommend you to try making this selector more spesific.

[BloodyIron]

@dimger is this addressed with the commits you posted on the repo for it? :D

[dimger]

@BloodyIron yes i think so :)

[BloodyIron]

@dimger could swear I posted here, but it's actually still broken for me. I updated with the new master branch (as of a few days ago) and when using the dashboard to enter an Express Entry, I still cannot see the pulldown menu to select the Single Express Entry but can in the same form select Multiple Express Entries from the other association. Any chance we can get your help again with this? :)

[BloodyIron]

@dimger @hissy I'm still stuck with this not working :( really would appreciate help sorting out the dashboard form issue. I haven't yet tested if the regular page forms is fixed or not as I'm still doing structural testing first.

[BloodyIron]

@mnakalay any chance we can get this baked into 8.5.5? Since it appears to be operational with the fix you mentioned in the other issue I was posting in : hissy/addon_multiple_express_entry_selector#4