New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Clarity of Version Scheduling Interface #11731
base: 9.3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks interesting! We should be able to do all this without any new inline styles. Just use Font awesome for your icons. I don't want to have custom CSS here. Also I agree with mlocati there's no reason to have the strings live in a separate spot, just put them inline wherever they're being printed out.
I’ve replaced all custom SVGs with Font Awesome icons and removed inline styles in favor of minimal, class-based CSS essential for the toggle functionality. Additionally, text strings are now placed directly where needed. |
I wanted to check if there's anything else needed on my end for PR #11731. I have implemented the changes you suggested and am wondering if there are any additional adjustments required. Your guidance on any further steps would be greatly appreciated. |
Thanks for the feedback. Scoped CSS with #version-scheduling to target relevant elements and avoid conflicts. Ready for another review – open to more suggestions or tasks! |
@mlocati Removed custom CSS with Bootstrap but now JS is required. |
This pull request endeavors to clarify the Version Scheduling feature by presenting clearer descriptions and info boxes to users. The modifications are aimed at ensuring a more intuitive user experience when scheduling versions for publication.
Technical Details:
Screenshots:
Additional Context:
This is my second pull request, inspired by feedback from clients using our Concrete CMS sites. The changes have been tested for consistency with the project's coding style guidelines by running the style fix.