Add default parameter values to method #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The \Concrete\Core\Controller\Controller::get method has a signature of get($identifier=null, $defaultValue=null). This signature was causing issues on PHP7.
|
This looks like it's probably extending the base method by accident, gotta leave it like this for backwards compatibility though. |
KorvinSzanto
added a commit
that referenced
this pull request
Feb 3, 2016
Add default parameter values to Feed::get method
|
Yeah, honestly we should change this method to something like output($identifier) instead of get(). We could leave the route the same and simply change the method it's calling, so no issue with backward compatibility. |
|
@aembler I just imagine that if someone has overridden this feed controller and extended the get method, their customizations will no longer apply since the route would be looking to a different method. That said, I agree that we should change this and keep track of the backwards incompatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The \Concrete\Core\Controller\Controller::get method has a signature of get($identifier=null, $defaultValue=null). This signature was causing issues on PHP7.