Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add separate header and footer tracking code inputs #3882

Merged
merged 5 commits into from Jun 3, 2016
Merged

add separate header and footer tracking code inputs #3882

merged 5 commits into from Jun 3, 2016

Conversation

MrKarlDilkington
Copy link
Contributor

@Remo
Copy link
Contributor

Remo commented May 26, 2016

shouldn't there be a migration script that moves the old tracking code to the new one? Maybe I've missed something, but I think this would remove all existing tracking codes, wouldn't it?

@mlocati
Copy link
Contributor

mlocati commented May 26, 2016

shouldn't there be a migration script

MrKarlDilkington#1

@mlocati
Copy link
Contributor

mlocati commented May 26, 2016

@MrKarlDilkington MrKarlDilkington#1 should be merged before this PR is accepted

@MrKarlDilkington
Copy link
Contributor Author

@Remo

Thank you for pointing that out. I didn't take existing tracking codes into consideration.

@mlocati

Thank you for adding the version migration method. I didn't know this could be done. I am adding your commits to my notes.

@aembler
Copy link
Member

aembler commented Jun 3, 2016

This is great, thanks to both of you.

@aembler aembler merged commit 9d75501 into concretecms:develop Jun 3, 2016
KorvinSzanto pushed a commit that referenced this pull request Dec 12, 2016
@MrKarlDilkington @aembler
add separate header and footer tracking code inputs (#3882)
3211d2b 
* add separate header and footer tracking code inputs

* PSR

* Migrate tracking code

* Safer migration of tracking codes


Former-commit-id: 9d75501
Former-commit-id: 746d4461eed6837c287b115dd86eacf96b55fbf9
@MrKarlDilkington MrKarlDilkington deleted the combination_tracking_codes branch April 20, 2017 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrKarlDilkington @Remo @mlocati @aembler