BugFix: Load predefined attribute when creating new page by composer #4470
Conversation
| * @param mixed $var | ||
| * @return boolean | ||
| */ | ||
| function is_foreachable($var) |
There was a problem hiding this comment.
Can we remove this from the PR and open an issue to discuss whether we need this global function?
There was a problem hiding this comment.
Yes sure, the most important is the fix.
the global function is not really important.
|
This pull looks to break tests for some reason, can you resolve those test issues and reopen? |
|
This is already fixed in v8 Sent from my iPhone
|
|
@KorvinSzanto test issues come from previous commits, you can see the latest merged PR #4443 @aembler as the v8 is not ready for production we need to fix bugs for the v7 until you release the v8 |
|
@aembler I strongly support Hamed here. 5.8 isn't stable and won't be fully backwards compatible, having at least a stable 5.7 branch on github would help a lot. It would be nice to run 5.8 for all projects, but in the end I have to run a business those concrete5 updates aren't always as cheap as one would wish them to be. |
|
Fine, but I'm not sure this solution as written doesn't have unintended consequences |
|
@HamedDarragi maybe you want to have a look at older 5.7 version? I'm pretty sure this used to work not too long ago. |
Predefined attributes in /dashboard/pages/types/attributes/{ptID} are not being loaded when we create a new page.
@Remo