Feature/improved address attribute #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add integration to commerceguys/addressing and create a new service to format the addresses within concrete5.
This is required by the address formatting service because concrete5 wants to print out the state/province names in their full text format.
- Display the state province field only for countries in which that field is being used - Move the state/province field under the coutry field where it is more natural because the country select affects it (just like the postal code comes after the country field) - Refactor some of the code and class names to better reflect what they are now doing (not only state/province data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7943
In addition, this moves the state/province field under the country field in the address attribute, just like the postal code field. The current order of the fields is illogical and even worse for countries that do not require the state/province field (which is now hidden if it is not needed).
This supersedes PR #7944.