Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset token for r-forge #496

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

mbargull
Copy link
Member

Copying from cf-staging fails due to "invalid feedstock token".
refs:

cc @conda-forge/r-forge


Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

Copying from cf-staging fails due to "invalid feedstock token".
refs:
- conda-forge/r-forge-feedstock#8
@mbargull mbargull requested a review from a team as a code owner October 12, 2022 09:52
@beckermr beckermr merged commit bbfea07 into conda-forge:main Oct 12, 2022
@mbargull
Copy link
Member Author

Thanks for the merge!
But apparently there's something going on with Travis:
The last runs of https://github.com/conda-forge/admin-requests/actions/workflows/master.yml all show:

RuntimeError: Failed to register feedstock token for conda-forge/r-forge-feedstock on travis!
failed to reset token for 'r-forge': CalledProcessError(1, ['conda', 'smithy', 'register-feedstock-token', '--without-circle', '--without-drone', '--feedstock_directory', '/tmp/tmp1m5yxkun/r-forge-feedstock', '--organization', 'conda-forge', '--token_repo', 'https://x-access-token:${GITHUB_TOKEN}@github.com/conda-forge/feedstock-tokens'])

@beckermr
Copy link
Member

We are likely out of requests. Retry the workflow later. This workflow uses the same tokens and code as staged recipes.

@dpryan79
Copy link
Contributor

We're still running into invalid feedstock token errors.

@beckermr
Copy link
Member

Does a retry fix it ?

@dpryan79
Copy link
Contributor

I've retried the upload jobs from the master branch already without success. Should I try rerendering as well?

@dpryan79
Copy link
Contributor

Rerendering doesn't seem to update anything in this case.

@beckermr
Copy link
Member

Which feedstocks?

@dpryan79
Copy link
Contributor

Just r-forge that I've seen so far: https://github.com/conda-forge/r-forge-feedstock

@beckermr
Copy link
Member

Ah ok. Looks like Travis is still barfing on the token reset.

@beckermr
Copy link
Member

I'll have to debug locally but won't get a chance for a while. Is this a big blocker?

@dpryan79
Copy link
Contributor

Not a big one, no. It's only blocking a handful of packages in the R 4.2 migration, so it doesn't really matter if this gets addressed today or next week. Thanks!

@mbargull
Copy link
Member Author

Apart from the remaining r-v8 subgraph (about 40 feedstocks), this is now the "biggest" blocker with (if I counted correctly) 6 downstream feedstocks. So, yeah, not many -- but depending on how fast we can handle the r-v8 stuff, this could get to a "tail end of the R 4.2 migration" status ;).


All workflow runs of https://github.com/conda-forge/admin-requests/actions failed since merging this PR with token registration on Travis not working (see #496 (comment) ).
OTOH, registering token for new feedstocks seem to work no problem: https://github.com/conda-forge/staged-recipes/actions/workflows/create_feedstocks.yml

So might be rather specific to https://github.com/conda-forge/r-forge ? (Not sure if relevant/if it helps to pin point the issue: that feedstock also hasn't been built since the CFEP13 token cleanup migration.)

@beckermr
Copy link
Member

Travis appears to not have this feedstock on its website - https://app.travis-ci.com/github/conda-forge/r-forge-feedstock

IDK why. Maybe we can submit it to staged recipes again to see if that helps?

@beckermr
Copy link
Member

Or we could disable Travis here...

@mbargull
Copy link
Member Author

Thanks for looking into it!
Since the feedstock doesn't use Travis anyway, disabling it would be more than enough :).

@beckermr
Copy link
Member

Right ok. We'll have to make a special run of the feedstock token reset code or add that feature. I will try for today.

@beckermr
Copy link
Member

Try this again. The token has now been reset.

@mbargull
Copy link
Member Author

Thank you! Just started it and will check in 4-5 hours (afk).

@dpryan79
Copy link
Contributor

Seems to have done the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants