Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks qgrid as broken due to failing post-link script #508

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Nov 8, 2022

When installing qgrid as part of an existing environment, it will solve to the _3 version. This version is broken with changes to upstream packages (jupyter-nbclassic).

See:

conda-forge/qgrid-feedstock#37

conda-forge/qgrid-feedstock#35
quantopian/qgrid#378
tardis-sn/tardis#2137

Rolling back transaction: done

LinkError: post-link script failed for package conda-forge::qgrid-1.3.1-pyhd8ed1ab_3
location of failed script: /home/afullard/.conda/envs/tardis2/bin/.qgrid-post-link.sh
==> script messages <==
<None>
==> script output <==
stdout: 
stderr: 
return code: 1

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

ping @conda-forge/qgrid-feedstock

```ERROR conda.core.link:_execute(701): An error occurred while installing package 'conda-forge::qgrid-1.3.1-pyhd8ed1ab_3'.
Rolling back transaction: done

LinkError: post-link script failed for package conda-forge::qgrid-1.3.1-pyhd8ed1ab_3
location of failed script: /home/afullard/.conda/envs/tardis2/bin/.qgrid-post-link.sh
==> script messages <==
<None>
==> script output <==
stdout: 
stderr: 
return code: 1```
@andrewfullard andrewfullard requested a review from a team as a code owner November 8, 2022 16:21
@ocefpaf ocefpaf merged commit 2e20cad into conda-forge:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants