-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ucx dependency for now #963
Remove ucx dependency for now #963
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for the PR. You'll have to adapt build.sh as well (it might work without adaptation but it would be confusing). The commit history resp. git blame should be relatively self-explanatory I hope. :) |
6fec278
to
bd168f1
Compare
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.02.16.11.04.46
cc @kkraus14 |
I'm hoping we can solve this on the We already have a change for For example issue ( conda-forge/ucx-split-feedstock#66 ) proposes folding the CPU & GPU builds into one build and then making |
I agree that I'd much prefer to fix the UCX package than disable it in the libarrow builds if possible, but understand if there's a short term fix we need to make here in the meantime. |
Yes, this PR is only meant for "until the ucx issues is solved". But to me it seems quite unsure what would be the exact timeline for getting those fixes in for ucx 1.14 (also just being unfamiliar with the package, I can't judge that), while I would consider the pyarrow issue as a serious regression in user experience (hugely blowing up every environment with pyarrow on linux), something we should fix on the short-term IMO. |
The timeout on aarch64, is that a known issue? Or could someone restart that build? |
Let's undo this regression (even though somewhat subjective), and then readd it once ucx is ready. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
FYI: now that conda-forge/ucx-split-feedstock#111 has landed, I added a PR to re-enable ucx support in #1011 |
See #962 (comment)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)