Fix library installation directory #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
force-pushed
the
fix_lib_install_dir
branch
from
2b7704d
to
e81899d
Compare
jakirkham
force-pushed
the
fix_lib_install_dir
branch
from
e81899d
to
1877e20
Compare
Rebuild now that libraries are installed correctly.
jakirkham
force-pushed
the
fix_lib_install_dir
branch
from
1877e20
to
7e1c61d
Compare
|
Seems to still be installing the DLL in Edit: Folding into issue ( WebAssembly/binaryen#1633 ). |
|
I think this should be fixed now. |
|
Done in PR ( #38 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Libraries were being installed to
lib64, but they should be installed tolib. Also thedllwas installed inlibinstead ofbin. This fixes those issues.Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)