Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug #23

Closed
wants to merge 56 commits into from
Closed

Debug #23

wants to merge 56 commits into from

Conversation

h-vetinari
Copy link
Member

Trying to debug flame/blis#514

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@conda-forge/help-c-cpp, with the help of some numpy folks, I've managed to figure out some of the numpy failures with blis, and opened an issue upstream. The developers there asked me to build and run a (potential) C-reproducer, but I cannot seem to get the compilation to work here.

Pointers would be much appreciated. 🙃

@isuruf
Copy link
Member

isuruf commented Jul 1, 2021

What's the error you are getting? Wouldn't it be better to test in numpy-feedstock where the turnaround time is less due to blis being already compiled?

@h-vetinari
Copy link
Member Author

What's the error you are getting?

Error is:

+ /home/conda/feedstock_root/build_artifacts/blis_1625166386839/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/bin/x86_64-conda-linux-gnu-cc -I/home/conda/feedstock_root/build_artifacts/blis_1625166386839/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/include debug_blis.c
debug_blis.c:1:10: fatal error: blis.h: No such file or directory
    1 | #include <blis.h>

Which surprises me, because I'm explicitly including $PREFIX/include, and blis.h is tested to be in there.

Wouldn't it be better to test in numpy-feedstock where the turnaround time is less due to blis being already compiled?

I've thought about that, but the turn-around isn't massively better (in fact worse for all but windows), but more importantly IMO, if there are patches for blis to try out, this is the feedstock to try them out with - hence why I chose this feedstock.

recipe/debug_blis.c Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@h-vetinari
Copy link
Member Author

Thanks a lot for the help here, would have been a slow process...

I was wondering if the windows incantation needs something for the runtime linkage as well - e.g. /MT or so?

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: H. Vetinari <h.vetinari@gmx.com>
recipe/build.sh Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
@h-vetinari
Copy link
Member Author

This PR has served its purpose, closing.

@h-vetinari h-vetinari closed this Oct 12, 2021
@h-vetinari h-vetinari deleted the debug branch October 12, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants