Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boost-cpp #27

Merged
merged 2 commits into from
Jan 22, 2017
Merged

Use boost-cpp #27

merged 2 commits into from
Jan 22, 2017

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jan 6, 2017

Fixes #1

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller
Copy link
Contributor

should you not disable all other sub-libs ?

@@ -45,6 +45,7 @@ LINKFLAGS="${LINKFLAGS} -L${LIBRARY_PATH}"
cxxflags="${CXXFLAGS}" \
linkflags="${LINKFLAGS}" \
--layout=system \
--with-python \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschueller, when this is given only python lib is built. You can see that in the logs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok sorry

@isuruf
Copy link
Member Author

isuruf commented Jan 7, 2017

I'm getting a weird error in appveyor x64 builds. Any suggestions?

[00:02:43] Downloading http://sourceforge.net/projects/boost/files/boost/1.63.0/boost_1_63_0.tar.bz2
[00:02:54] Success
[00:03:32] Traceback (most recent call last):
[00:03:32]   File "C:\Miniconda-x64\Scripts\conda-build-script.py", line 5, in <module>
[00:03:32]     sys.exit(conda_build.cli.main_build.main())
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\cli\main_build.py", line 312, in main
[00:03:32]     execute(sys.argv[1:])
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\cli\main_build.py", line 304, in execute
[00:03:32]     already_built=None, config=config, noverify=args.no_verify)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\api.py", line 86, in build
[00:03:32]     need_source_download=need_source_download, config=config)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\build.py", line 1427, in build_tree
[00:03:32]     config=config)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\build.py", line 948, in build
[00:03:32]     config=config)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\render.py", line 87, in parse_or_try_download
[00:03:32]     source.provide(metadata, config=config)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\source.py", line 498, in provide
[00:03:32]     unpack(metadata, config=config)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\source.py", line 88, in unpack
[00:03:32]     tar_xf(src_path, config.work_dir)
[00:03:32]   File "C:\Miniconda-x64\lib\site-packages\conda_build\utils.py", line 313, in tar_xf
[00:03:32]     t.extractall(path=dir_path)
[00:03:32]   File "C:\Miniconda-x64\lib\tarfile.py", line 2079, in extractall
[00:03:32]     self.extract(tarinfo, path)
[00:03:32]   File "C:\Miniconda-x64\lib\tarfile.py", line 2116, in extract
[00:03:32]     self._extract_member(tarinfo, os.path.join(path, tarinfo.name))
[00:03:32]   File "C:\Miniconda-x64\lib\tarfile.py", line 2192, in _extract_member
[00:03:32]     self.makefile(tarinfo, targetpath)
[00:03:32]   File "C:\Miniconda-x64\lib\tarfile.py", line 2232, in makefile
[00:03:32]     with bltn_open(targetpath, "wb") as target:
[00:03:32] IOError: [Errno 2] No such file or directory: 'C:\\Miniconda-x64\\conda-bld\\recipe_1483772488890\\work\\boost_1_63_0\\libs\\geometry\\doc\\html\\geometry\\reference\\spatial_indexes\\boost__geometry__index__rtree\\rtree_parameters_type_const____indexable_getter_const____value_equal_const____allocator_type_const___.html'
[00:03:33] Command exited with code 1

@jschueller
Copy link
Contributor

jschueller commented Jan 7, 2017

file path limit ?
this is pretty long: boost_1_63_0/libs/geometry/doc/html/geometry/spatial_indexes/creation_and_modification.html
maybe it fails on x64 because the location crosses the limit since there's a "-x64" suffix in CONDA_INSTALL_LOCN=C:\Miniconda-x64

@isuruf
Copy link
Member Author

isuruf commented Jan 7, 2017

Probably. without -x64 it is 256 chars long and with -x64 it is 260 chars long.
What I don't get is why it didn't fail before.

@jschueller
Copy link
Contributor

it was conda-build 1.x ?

@isuruf
Copy link
Member Author

isuruf commented Jan 7, 2017

Yes, that seems to be the case. @msarahan, any suggestions?

@jschueller
Copy link
Contributor

@isuruf that's definitively it: the build dir changed from conda-bld/work from conda-bld/recipe_[unixtime] which is much longer, got the same problem for another recipe

@isuruf
Copy link
Member Author

isuruf commented Jan 7, 2017

Thanks @jschueller for the info. Can you open an issue in conda-build ?

@jakirkham
Copy link
Member

We just updated to conda-build 2 the other day. Undoubtedly there may be some issues we uncover. However, unlike conda-build 1 we will get better support.

@isuruf
Copy link
Member Author

isuruf commented Jan 8, 2017

It works on my fork, so I created conda-forge/conda-smithy/pull/419

@isuruf
Copy link
Member Author

isuruf commented Jan 14, 2017

@jakirkham, Look at the last build.

C:\bld\recipe_1484368660609       # conda-build 2.x with this PR
C:\Miniconda3-x64\conda-bld       # conda-build 1.x

@jakirkham
Copy link
Member

Nice! Looks good. Let's add that to conda-forge-build-setup. Could you please do a PR?

@isuruf
Copy link
Member Author

isuruf commented Jan 22, 2017

Deleted the changes for build directory as it is now in conda-forge-build-setup.
Tests pass now, except for one test in appveyor which fails due to a corrupt download.

@jschueller jschueller merged commit 4422b9d into conda-forge:master Jan 22, 2017
@jakirkham
Copy link
Member

Appears to have passed on master. Thanks for doing this, @isuruf.

@jakirkham
Copy link
Member

jakirkham commented Jan 22, 2017

Though it does seem we are missing the headers for Boost.Python in Linux and OS X packages. Windows packages seem to include all the headers for all of Boost. 😕

Edit: Raised as issue ( #29 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants