-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build both release and debug for Windows #35
Conversation
So if we were to do it on Windows, we should probably do it on Unix. Also we would need a build number bump. |
That all said, what is your interest in having debug builds of Boost? Why it would be a good idea to have them included in a large stack like conda-forge? What possible issues could it cause? |
I think windows is special, in that if you want a debug build of your library, you need to have debug libraries of all your dependencies. |
I'm trying to build Arrow https://github.com/apache/arrow statically on Windows in Debug. Conda-forge provides only release static build of boost, but it's not compatible with debug static builds by MSVC toolchain (different runtimes are used). |
Right. So this is not the first time debug builds have come up on Windows. Most notably this has been discussed with Python. However, I think we need to come to some consensus about how this should look for the stack as opposed to adding it piecemeal to packages of interest. While the latter is expedient, it is almost certainly going to end in breakage if we don't have some consensus about how this is done. I would propose that a few interested people put together a CFEP that lays out the right way to do debug builds and how they are enabled. I think that will make it easier to see what works best and will serve conda-forge best. cc @tadeu @wesm @dfroger @conda-forge/core xref: conda-forge/python-feedstock#73 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jakirkham my understanding is that Boost is designed to be able to build both release and debug builds on Windows (https://theboostcpplibraries.com/introduction-installation), so at least in this special case I don't believe there is necessarily a conflict In general, for libraries that need to statically link symbols, it would be useful to be able to use pre-built libraries from conda-forge where possible during development. |
Note that there are three different "flags" that control different aspects of "debug" in Boost (source):
In practice, either
I think that if |
@Maxris I don't know if it should all be in the same package: it will more than double the package size, and most people won't ever use the debug libraries. Plus, there are some libraries such as Perhaps a different package that depends on the |
I agree with tadeu. |
FWIW this is still a great idea that we should really revive it (especially as the tooling has caught up a bit). Raised issue ( conda-forge/conda-forge.github.io#544 ) to discuss how we do split packages and generate things like debug builds as products. |
No description provided.