Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do cfitsio410 migration and other touchups #70

Merged
merged 5 commits into from
Sep 10, 2022

Conversation

conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #69.

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Do cfitsio410 migration Sep 9, 2022
Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why the harsh pinnings were in place but this should help the migrations moving forward

recipe/meta.yaml Show resolved Hide resolved
@hmaarrfk hmaarrfk changed the title Do cfitsio410 migration Do cfitsio410 migration and other fixes Sep 9, 2022
@hmaarrfk hmaarrfk changed the title Do cfitsio410 migration and other fixes Do cfitsio410 migration and other touchups Sep 9, 2022
Copy link
Contributor

@pkgw pkgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Were there any other changes that you wanted to include here? If not I can go ahead and merge.

@hmaarrfk hmaarrfk merged commit be9b134 into conda-forge:main Sep 10, 2022
@hmaarrfk
Copy link
Contributor

No this is it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants