ENH CI setup and an example #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP code to generate and build the CDTs
|
ok @conda-forge/core @conda-forge/help-cdts This PR is ready for review! |
|
Very nice! |
jakirkham
reviewed
Jul 13, 2020
jakirkham
reviewed
Jul 13, 2020
jakirkham
reviewed
Jul 13, 2020
jakirkham
reviewed
Jul 13, 2020
jakirkham
reviewed
Jul 13, 2020
| ): | ||
| cdt_name = distro | ||
| bits = "32" if architecture in ("armv6", "armv7a", "i686", "i386") else "64" | ||
| base_architectures = dict({"i686": "i386"}) |
There was a problem hiding this comment.
What's the significance of base_architectures? Would it make sense to add a comment above?
There was a problem hiding this comment.
This was in the upstream code, so IDK. Maybe @mingwandroid can comment?
|
Thanks for the comments @jakirkham! I made two issues for the ones I'd like to address later. |
|
any more comments here @conda-forge/core ? |
|
Thanks Matt! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all of the initial code needed for the CDT builds.
Note that it won't actually upload anything yet as I have not put in the proper token on azure. Once we are confident the CDT recipes are correct, I will add the token.
cc @conda-forge/help-cdts @conda-forge/core