Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipping PyPy #28

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

ChrisBarker-NOAA
Copy link
Contributor

didn't bump build number, as this shouldn't change any other builds, just skip PyPy

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@wshanks
Copy link

wshanks commented Mar 7, 2024

Remember to rerender 🙂

@ChrisBarker-NOAA
Copy link
Contributor Author

@conda-forge-admin please rerender

@ChrisBarker-NOAA
Copy link
Contributor Author

thanks @wshanks -- I never quite know when I need to do that -- din't think I needed to with a recipe change. Hope I"ll remember that next time.

@wshanks
Copy link

wshanks commented Mar 7, 2024

I get bitten by it too sometimes. The pre-processing selectors (the comments) get used in the rendering step to generate the .ci_support files which define the different CI build jobs, so if you don't rerender the old job configurations don't get updated.

@ChrisBarker-NOAA ChrisBarker-NOAA merged commit d07ffb7 into conda-forge:main Mar 7, 2024
14 checks passed
@ChrisBarker-NOAA
Copy link
Contributor Author

Thanks! that explanation makes sense -- maybe I'll remember next time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants