-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make noarch #7
Make noarch #7
Conversation
…da-forge-pinning 2019.01.21
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@ocefpaf I would like to use this package on Windows (well, not me personally - my Windows people would like to use it). This pull request was initially intended to make cfunits build on Windows but I noticed that, I think, it should work just fine as a noarch package. I believe all of its dependencies run on Windows so that should be fine. Does that make sense? |
If the package does not have compiled extensions then it does makes sense. The |
@ocefpaf Thanks. I asked you because you seemed to be the biggest contributor to the feedstock. I filed an issue with the cfunits developers over at Bitbucket. We'll see what they say. @cehbrecht, I'm not sure what your connection is to cfunits but you're listed as a maintainer of the feedstock. Do you have any thoughts? |
No problem. But sometimes I package so many things and I don't really know the source code in depth.
Thanks! If we don't get an answer we can try to merge, test, and if things are broken revert it later. |
@ocefpaf It's just about been a week and I've not heard back. What do you think, should we go ahead and merge? |
Let's give it a try, if it breaks the package we can remove it later. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This pull request makes cfunits a noarch package.