Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make noarch #7

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Make noarch #7

merged 3 commits into from
Jan 31, 2019

Conversation

mcflugen
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This pull request makes cfunits a noarch package.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mcflugen
Copy link
Contributor Author

mcflugen commented Jan 24, 2019

@ocefpaf I would like to use this package on Windows (well, not me personally - my Windows people would like to use it). This pull request was initially intended to make cfunits build on Windows but I noticed that, I think, it should work just fine as a noarch package. I believe all of its dependencies run on Windows so that should be fine.

Does that make sense?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 24, 2019

Does that make sense?

If the package does not have compiled extensions then it does makes sense. The setup.py imports Extension in the first line but I do not believe it is used. Maybe it is better to ask someone that is more familiar with the source code before merging this.

@mcflugen
Copy link
Contributor Author

@ocefpaf Thanks. I asked you because you seemed to be the biggest contributor to the feedstock. I filed an issue with the cfunits developers over at Bitbucket. We'll see what they say.

@cehbrecht, I'm not sure what your connection is to cfunits but you're listed as a maintainer of the feedstock. Do you have any thoughts?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 24, 2019

@ocefpaf Thanks. I asked you because you seemed to be the biggest contributor to the feedstock.

No problem. But sometimes I package so many things and I don't really know the source code in depth.

I filed an issue with the cfunits developers over at Bitbucket. We'll see what they say.

Thanks! If we don't get an answer we can try to merge, test, and if things are broken revert it later.

@mcflugen
Copy link
Contributor Author

mcflugen commented Jan 30, 2019

@ocefpaf It's just about been a week and I've not heard back. What do you think, should we go ahead and merge?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 31, 2019

@ocefpaf It's just about been a week and I've not heard back. What do you think, should we go ahead and merge?

Let's give it a try, if it breaks the package we can remove it later.

@ocefpaf ocefpaf merged commit 6e4c27e into conda-forge:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants