Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to noarch #3

Merged
merged 3 commits into from Nov 25, 2020
Merged

Conversation

mattwthompson
Copy link
Member

I got confused with the outputs: syntax in #1 and, along the way, removed noarch. This attempts to fix that.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattwthompson
Copy link
Member Author

I don't understand why the array of OS are still being built - for comparison, the black feedstock only builds on Linux and I'm using identical syntax AFAICT

https://github.com/conda-forge/black-feedstock/blob/d4b6e4600258557d31c53603ecbd91376dff8826/recipe/meta.yaml

@jaimergp
Copy link
Member

Always rerender in case of doubt!

@conda-forge-admin, please rerender

@mattwthompson
Copy link
Member Author

Aha, that did the trick!

@jaimergp
Copy link
Member

Nice. If the local tests are still ok with full noarch now, go ahead and merge!

Copy link

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMILES is pure python, so from a high level, noarch builds should be fine. I won't be able to dedicate time to figuring out the test status until I'm back to work next week so I'll leave it to you to ensure they're passing :-)

@mattwthompson
Copy link
Member Author

I'm quickly double-checking again by installing the tarball from artifacts onto a Linux machine

@mattwthompson
Copy link
Member Author

Everything looks good locally (none of these were strictly necessary, but helps me sleep better)

  • Installing noarch/cmiles-base-0.1.6-pyhd8ed1ab_2.tar.bz2 into a minimal-ish fresh environment provides the package, which ...
  • Fails to import with no toolkits installed (expected)
  • Imports with either toolkit installed
  • Works with multiple Python versions
  • Tests passed, run from the unpacked src_cache/

@mattwthompson mattwthompson merged commit 686399b into conda-forge:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants