Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh requirements #101

Merged
merged 5 commits into from
Jul 12, 2019

Conversation

jakirkham
Copy link
Member

Updates conda-build's requirements based on it's included meta.yaml.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Now `conda-build` requires `setuptools` and a newer version of
`conda-package-handling`. So update the dependencies accordingly.
Rebuild now that conda-build's dependencies have been updated.
@jakirkham jakirkham requested a review from msarahan June 28, 2019 04:37
@jakirkham jakirkham requested a review from stuertz as a code owner June 28, 2019 04:37
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

jakirkham requested a review from stuertz as a code owner now

Weird. Definitely did not do that. Seems GitHub has a mind of its own.


Though I did request a review from you Mike. 🙂

@jakirkham jakirkham removed the request for review from stuertz June 28, 2019 14:15
@isuruf
Copy link
Member

isuruf commented Jun 30, 2019

@jakirkham, can you add ripgrep too? #102

@jakirkham
Copy link
Member Author

Let’s handle that separately. Right now I just want to get the requirements correct, which they are not currently.

@jakirkham
Copy link
Member Author

@msarahan, could you give this a quick look please?

recipe/meta.yaml Outdated Show resolved Hide resolved
@msarahan
Copy link
Member

msarahan commented Jul 1, 2019

bump CPH, otherwise fine

@jakirkham
Copy link
Member Author

Thanks for giving it a look. Can do. 🙂

Co-Authored-By: Mike Sarahan <msarahan@gmail.com>
@scopatz
Copy link
Member

scopatz commented Jul 2, 2019

Looks like it is failing on mac

@jakirkham
Copy link
Member Author

Sounds like some sort of other issue outside of this PR then. Presumably we were already using the latest version of conda-package-handling, which is already 1.3+.

@scopatz
Copy link
Member

scopatz commented Jul 3, 2019

Yeah, I am seeing this in staged-recipes too: conda-forge/staged-recipes#8651

@jakirkham
Copy link
Member Author

Yeah it affected the JupyterLab 1.0.1 PR too ( conda-forge/jupyterlab-feedstock#158 ).

@mariusvniekerk
Copy link
Member

Restarted the failed builds and seems to be okay now

@jakirkham
Copy link
Member Author

FWIW we probably don't want to merge this until we are ready to go back to the new version of conda-build.

@mariusvniekerk
Copy link
Member

Or until we have some patches (eeew) that make it work

@mariusvniekerk
Copy link
Member

I'm not entirely sure what the build errors are on the emulated platforms. It suggests that there may be some issues with how qemu operates since we moved to 4.0.0-5 Should we roll that back to the last good 3.x release?

@jjhelmus
Copy link
Contributor

I'm not entirely sure what the build errors are on the emulated platforms. It suggests that there may be some issues with how qemu operates since we moved to 4.0.0-5 Should we roll that back to the last good 3.x release?

These errors have been seen in a few other recipes:

If reverting to qemu 3.x fixes this I would be in favor.

@mbargull
Copy link
Member

Looks like @mariusvniekerk is spot-on:

>>> docker run --rm -it --entrypoint='' mbargull/condaforge-linux-anvil-aarch64:qemu-3.1.0-3 /opt/conda/bin/python -c 'import os;os.listxattr(".");print("all good")'
all good
>>> docker run --rm -it --entrypoint='' mbargull/condaforge-linux-anvil-aarch64:qemu-4.0.0-5 /opt/conda/bin/python -c 'import os;os.listxattr(".");print("all good")'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
OSError: [Errno 38] Function not implemented: '.'

@mariusvniekerk
Copy link
Member

Reverted to qemu 3.1 and its now fine

@jakirkham
Copy link
Member Author

Ok, feel free to merge then 🙂

@mariusvniekerk mariusvniekerk merged commit d6988ec into conda-forge:master Jul 12, 2019
@jakirkham jakirkham deleted the refresh_reqs branch July 19, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants