-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh requirements #101
Refresh requirements #101
Conversation
Now `conda-build` requires `setuptools` and a newer version of `conda-package-handling`. So update the dependencies accordingly.
Rebuild now that conda-build's dependencies have been updated.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Weird. Definitely did not do that. Seems GitHub has a mind of its own. Though I did request a review from you Mike. 🙂 |
@jakirkham, can you add ripgrep too? #102 |
Let’s handle that separately. Right now I just want to get the requirements correct, which they are not currently. |
@msarahan, could you give this a quick look please? |
bump CPH, otherwise fine |
Thanks for giving it a look. Can do. 🙂 |
Co-Authored-By: Mike Sarahan <msarahan@gmail.com>
Looks like it is failing on mac |
Sounds like some sort of other issue outside of this PR then. Presumably we were already using the latest version of |
Yeah, I am seeing this in staged-recipes too: conda-forge/staged-recipes#8651 |
Yeah it affected the JupyterLab 1.0.1 PR too ( conda-forge/jupyterlab-feedstock#158 ). |
Restarted the failed builds and seems to be okay now |
FWIW we probably don't want to merge this until we are ready to go back to the new version of conda-build. |
Or until we have some patches (eeew) that make it work |
I'm not entirely sure what the build errors are on the emulated platforms. It suggests that there may be some issues with how qemu operates since we moved to 4.0.0-5 Should we roll that back to the last good 3.x release? |
These errors have been seen in a few other recipes:
If reverting to qemu 3.x fixes this I would be in favor. |
Looks like @mariusvniekerk is spot-on: >>> docker run --rm -it --entrypoint='' mbargull/condaforge-linux-anvil-aarch64:qemu-3.1.0-3 /opt/conda/bin/python -c 'import os;os.listxattr(".");print("all good")'
all good
>>> docker run --rm -it --entrypoint='' mbargull/condaforge-linux-anvil-aarch64:qemu-4.0.0-5 /opt/conda/bin/python -c 'import os;os.listxattr(".");print("all good")'
Traceback (most recent call last):
File "<string>", line 1, in <module>
OSError: [Errno 38] Function not implemented: '.' |
Reverted to qemu 3.1 and its now fine |
Ok, feel free to merge then 🙂 |
Updates conda-build's requirements based on it's included
meta.yaml
.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)