Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH strict channel priority for linux #110

Merged
merged 7 commits into from
Jul 24, 2020
Merged

ENH strict channel priority for linux #110

merged 7 commits into from
Jul 24, 2020

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Jul 24, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR turns on strict channel priority for linux on all builds.

cc @isuruf @ocefpaf @conda-forge/core

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member Author

@conda-forge-admin rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@beckermr
Copy link
Member Author

Great @xhochy! I want to make sure @isuruf sees this before it goes in as well.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 24, 2020

So happy this is finally going in! I've been pushing for this since before Matt was a member :-)

@beckermr
Copy link
Member Author

@ocefpaf did you want to enable this for all platforms? Right now this PR only does this for linux.

@isuruf
Copy link
Member

isuruf commented Jul 24, 2020

In the last meeting, there was a request to add a conda-forge.yml option for this.

@jjhelmus
Copy link
Contributor

Is there a method for feedstocks to opt-out of this? There are a few packages that require tensorflow >=2 which is only available in defaults. Turning this on without an option to opt-out makes this un-buildable until new tensorflow packages are added to conda-forge or the older packages are removed.

@beckermr
Copy link
Member Author

ack - happy to do that

the default needs to be set to yes iiuic, right

@beckermr
Copy link
Member Author

thanks for the reminder all!

I will make a change to smithy. closing!

@beckermr beckermr closed this Jul 24, 2020
@beckermr beckermr deleted the linux-strict branch July 24, 2020 14:45
@jjhelmus
Copy link
Contributor

the default needs to be set to yes iiuic, right

That sounds great, default to strict but with an escape hatch for the handful of feedstock that need to opt-out

@isuruf
Copy link
Member

isuruf commented Jul 24, 2020

You can read conda-forge.yml here.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 24, 2020

@ocefpaf did you want to enable this for all platforms? Right now this PR only does this for linux.

I know. But it is a start ;-p
We need to get our act together on the scipy package to make the same on Windows. Not sure what are the hurdles on macOS.

@isuruf
Copy link
Member

isuruf commented Jul 24, 2020

There are no hurdles on macOS.

@beckermr beckermr restored the linux-strict branch July 24, 2020 14:50
@beckermr beckermr reopened this Jul 24, 2020
@ocefpaf
Copy link
Member

ocefpaf commented Jul 24, 2020

There are no hurdles on macOS.

Screenshot_20200724-120007

@xhochy
Copy link
Member

xhochy commented Jul 24, 2020

Please also make an announcement for this!

@beckermr
Copy link
Member Author

ok @ocefpaf @isuruf @xhochy @jjhelmus @conda-forge/core any other comments here?

@isuruf isuruf merged commit df1484b into conda-forge:master Jul 24, 2020
@beckermr
Copy link
Member Author

doc pull here: conda-forge/conda-forge.github.io#1112

@isuruf
Copy link
Member

isuruf commented Jul 24, 2020

Can you send a PR for docs too if you have the time?

@beckermr beckermr deleted the linux-strict branch July 24, 2020 15:53
@beckermr
Copy link
Member Author

LOL yup!

@isuruf
Copy link
Member

isuruf commented Jul 24, 2020

This is failing on osx,

2020-07-24T15:54:51.6438850Z +++ shyaml get-value channel_priority strict
2020-07-24T15:54:51.6456570Z cat: /conda-forge.yml: No such file or directory
2020-07-24T15:54:51.6967720Z Error: invalid path 'channel_priority', can't query subvalue 'channel_priority' of a leaf (leaf value is None).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants