-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cross-compilation with CUDA 12 #250
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
So this is doing the minimal changes of just not erroring out on CUDA 12 now. In an ideal world, that's all we need. It's possible we still have to iterate a bit, but since no-one is cross-compiling with CUDA 12 yet, this has no risk of breakage, so I'm putting it in. :) |
Think we also need to bump the version number
|
Gah, sorry for missing that. 😑 |
All good. This feedstock is a bit of a weird one |
Clearly my coffee hasn't kicked in yet. Apologies again. |
Looks good. Thanks! 🙏 Other people have missed the same thing before (self included). So wouldn't worry about it Curious to see how this goes 🙂 |
Trying to use CUDA 12 in conda-forge/arrow-cpp-feedstock#1120, and it fails unsurprisingly because the branches here make it so.
Also picking up a minor comment improvement from #236