Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross-compilation with CUDA 12 #250

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jul 14, 2023

Trying to use CUDA 12 in conda-forge/arrow-cpp-feedstock#1120, and it fails unsurprisingly because the branches here make it so.

Also picking up a minor comment improvement from #236

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari marked this pull request as ready for review July 15, 2023 08:59
@h-vetinari h-vetinari requested a review from a team as a code owner July 15, 2023 08:59
@h-vetinari
Copy link
Member Author

So this is doing the minimal changes of just not erroring out on CUDA 12 now. In an ideal world, that's all we need. It's possible we still have to iterate a bit, but since no-one is cross-compiling with CUDA 12 yet, this has no risk of breakage, so I'm putting it in. :)

@h-vetinari h-vetinari merged commit 679cbdc into conda-forge:main Jul 15, 2023
58 checks passed
@h-vetinari h-vetinari deleted the cross_12 branch July 15, 2023 09:02
@jakirkham
Copy link
Member

Think we also need to bump the version number

{% set version = "3.32.0" %}

@h-vetinari
Copy link
Member Author

Gah, sorry for missing that. 😑

@jakirkham
Copy link
Member

All good. This feedstock is a bit of a weird one

@h-vetinari
Copy link
Member Author

17fd535

Clearly my coffee hasn't kicked in yet. Apologies again.

@jakirkham
Copy link
Member

Looks good. Thanks! 🙏

Other people have missed the same thing before (self included). So wouldn't worry about it

Curious to see how this goes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants