Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GCC 10, clang 12 #2010

Merged
merged 5 commits into from
Feb 17, 2022
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 13, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner October 13, 2021 21:58
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using major compiler versions to demark psuedo-epochs in the compiler stack in order to help ease the transitions to new features/packages. For example, we did this with the sysroot work.

Before we do this, is there anything we want to bump and/or change?

@isuruf
Copy link
Member Author

isuruf commented Oct 13, 2021

I can't think of anything to change.

@h-vetinari
Copy link
Member

Based on how I read the compatibility matrix for CUDA, this could (should?) also bump to GCC 10 for CUDA 11.1+

Co-authored-by: jakirkham <jakirkham@gmail.com>
@isuruf isuruf marked this pull request as draft January 27, 2022 21:30
@isuruf isuruf marked this pull request as ready for review February 3, 2022 18:57
@isuruf isuruf marked this pull request as draft February 3, 2022 18:59
@isuruf isuruf marked this pull request as ready for review February 16, 2022 19:22
@isuruf isuruf requested a review from a team February 16, 2022 19:23
@h-vetinari
Copy link
Member

h-vetinari commented Feb 17, 2022

I have an open comment how we can/should deal with this in staged recipes (the answer may be "do nothing", though then we'd either have to stay on GCC 9 or drop CUDA <=11.0 in staged recipes, unless I'm overlooking something somewhere...).

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment resolved, looking forward to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants