use numpy 1.19 consistently for python & pypy 3.8/3.9 #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Do we need to rebuild anything with this change? |
|
No, because conda-forge/numpy-feedstock#263 hasn't been merged yet, and therefore the migrator has not yet even opened a PR for any package dependent on numpy. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the backport turned out to work without issue (cf. conda-forge/numpy-feedstock#264; most of the changes were backports from work that had happened since then on master/main), I propose to use the same numpy host-version across cpython/pypy 3.8 & 3.9. I've also prepared backports for 1.20 & 1.21 so we can then consistently bump the version according to NEP29.