Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration for Python 3.12 #4914

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add migration for Python 3.12 #4914

merged 3 commits into from
Sep 21, 2023

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Sep 18, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@xhochy xhochy requested a review from a team as a code owner September 18, 2023 18:07
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy
xhochy commented Sep 18, 2023
View reviewed changes
recipe/migrations/python312.yaml
Comment on lines +34 to +35
channel_sources:
- conda-forge/label/python_rc,conda-forge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As one can see in https://github.com/conda-forge/pydantic-core-feedstock/pull/63/files, this line has sadly no effect. I would be happy for support on how to achieve this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a new release of conda-smithy, then we're good to go.

@xhochy @0xbe7a
Apply suggestions from code review
5bfca98 
Co-authored-by: Bela Stoyan <bela.stoyan@gmail.com>
@hmaarrfk
Copy link
Contributor

great work.

@xhochy xhochy mentioned this pull request Sep 19, 2023
Closed
isuruf
isuruf previously requested changes Sep 19, 2023
View reviewed changes
recipe/migrations/python312.yaml
Comment on lines +31 to +32
additional_zip_keys:
- channel_sources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conda-forge/conda-smithy#1764 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would release conda-smithy 3.26.2 later and would wait for a merge of conda-forge/cross-python-feedstock#74. Are then all concerns regarding the migration addressed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@xhochy xhochy merged commit 3778894 into conda-forge:main Sep 21, 2023
4 checks passed
@xhochy xhochy deleted the python312 branch September 21, 2023 07:10
@jakirkham jakirkham mentioned this pull request Oct 10, 2023
Open
This was referenced Apr 20, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@0xbe7a 0xbe7a 0xbe7a left review comments

@ocefpaf ocefpaf ocefpaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xhochy @hmaarrfk @ocefpaf @isuruf @0xbe7a