Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the numpy version of python 3.12 to 1.26 not 1.22 #5841

Merged
merged 1 commit into from
May 4, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented May 4, 2024

xref: conda-forge/conda-forge.github.io#1997 (comment)
Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested a review from a team as a code owner May 4, 2024 22:34
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented May 4, 2024

09f6263 did not revert things correctly.

The version was always 1.26

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label May 4, 2024
@github-actions github-actions bot merged commit ec31d50 into conda-forge:main May 4, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented May 4, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari
Copy link
Member

Ugh, sorry about the churn here. I was on my way out and not prepared for emergency handling 😬

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented May 5, 2024

All good. I skipped a review process as well given I took the time to find the historic commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants