Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix distributed <2.11.0 to bound msgpack-python #32

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Feb 26, 2020

Adjust the requirements of distributed <2.11.0 to bound msgpack-python
to less than 1.0.0

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Adjust the requirements of distributed <2.11.0 to bound msgpack-python
to less than 1.0.0
@jjhelmus jjhelmus requested a review from a team as a code owner February 26, 2020 19:34
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member

Ahhhhhhh!

I think this one explains a pin I had to put somewhere else.

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge if tests pass.

@jjhelmus
Copy link
Contributor Author

@jrbourbeau was interested in this as well

@jjhelmus
Copy link
Contributor Author

@beckermr Thanks for the fix, apparently writing code during a meeting is not a good idea 😄.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @jjhelmus! I'm +1 for adding a msgpack-python <1.0.0 constraint to older (<2.11.0) versions of distributed

@beckermr beckermr merged commit ed3ce9d into conda-forge:master Feb 26, 2020
@beckermr
Copy link
Member

Woops! I got trigger happy on the merge button here! Sorry @jakirkham !

@beckermr
Copy link
Member

Ack sorry all. This code will patch all versions of distributed, not just less 2.11.0. We will need to back it out and change it to patch only certain versions.

@jjhelmus
Copy link
Contributor Author

jjhelmus commented Feb 26, 2020

Ack sorry all. This code will patch all versions of distributed, not just less 2.11.0

The if 'msgpack-python' in record['depends']: line will only match below 2.11.0, newer versions of distributed have msgpack-python >=0.6.0 in the depends list.

@jakirkham
Copy link
Member

Woops! I got trigger happy on the merge button here! Sorry @jakirkham !

Nothing to be sorry about. Thanks for merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants