-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix distributed <2.11.0 to bound msgpack-python #32
hotfix distributed <2.11.0 to bound msgpack-python #32
Conversation
Adjust the requirements of distributed <2.11.0 to bound msgpack-python to less than 1.0.0
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ahhhhhhh! I think this one explains a pin I had to put somewhere else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to merge if tests pass.
@jrbourbeau was interested in this as well |
@beckermr Thanks for the fix, apparently writing code during a meeting is not a good idea 😄. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this @jjhelmus! I'm +1 for adding a msgpack-python <1.0.0
constraint to older (<2.11.0) versions of distributed
Woops! I got trigger happy on the merge button here! Sorry @jakirkham ! |
Ack sorry all. This code will patch all versions of distributed, not just less 2.11.0. We will need to back it out and change it to patch only certain versions. |
The |
Nothing to be sorry about. Thanks for merging 😄 |
Adjust the requirements of distributed <2.11.0 to bound msgpack-python
to less than 1.0.0
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)