Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort Python pin #392

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix isort Python pin #392

merged 1 commit into from
Jan 31, 2023

Conversation

RyanClark2k
Copy link
Contributor

@RyanClark2k RyanClark2k commented Jan 30, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

isort 5.11.0 dropped support for Python 3.6 (release) and isort 5.12.0 dropped support for Python 3.7 (release). In neither case did they update the Python pin in isort-feedstock. This has been since been fixed: conda-forge/isort-feedstock#78. This PR patches the affected versions. Below is the output of show_diff.py:

noarch::isort-5.11.1-pyhd8ed1ab_0.conda
-    "python >=3.6,<4.0",
+    "python >=3.7,<4.0",
noarch::isort-5.11.2-pyhd8ed1ab_0.conda
-    "python >=3.6,<4.0",
+    "python >=3.7,<4.0",
noarch::isort-5.11.3-pyhd8ed1ab_0.conda
-    "python >=3.6,<4.0",
+    "python >=3.7,<4.0",
noarch::isort-5.11.4-pyhd8ed1ab_0.conda
-    "python >=3.6,<4.0",
+    "python >=3.7,<4.0",
noarch::isort-5.11.4-pyhd8ed1ab_1.conda
-    "python >=3.6,<4.0",
+    "python >=3.7,<4.0",
noarch::isort-5.12.0-pyhd8ed1ab_0.conda
-    "python >=3.6,<4.0",
+    "python >=3.8,<4.0",

This correctly patches all affected versions. Note that isort-5.11.0 was never published to Conda Forge, and isort-5.12.0-pyhd8ed1ab_1 contains the fix already. Thank you for reviewing this contribution, cheers!

@RyanClark2k RyanClark2k requested a review from a team as a code owner January 30, 2023 15:49
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 0dc34f2 into conda-forge:main Jan 31, 2023
@RyanClark2k RyanClark2k deleted the fix-isort-python-pin branch February 1, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants