Gensim - add missing fuzzytm run dependency

[PrimozGodec]

Checklist

• Ran python show_diff.py and posted the output as part of the PR.
• Modifications won't affect packages built in the future.

How I found the error. When the bot proposed the new release for the orange3-text package, it didn't go through because of this missing package. Take a look at the building log: conda-forge/orange3-text-feedstock#63

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[PrimozGodec]

Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata.json.bz2
linux-64::gensim-4.3.0-py310h9b08913_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-64::gensim-4.3.0-py38ha32d0c5_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-64::gensim-4.3.0-py38hdc8b05c_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-64::gensim-4.3.0-py39h2ad29b5_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-64::gensim-4.3.0-py39h3aff93f_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
Downloading: https://conda.anaconda.org/conda-forge/linux-armv7l/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-armv7l/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-aarch64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-aarch64/repodata.json.bz2
linux-aarch64::gensim-4.3.0-py310hc3d6b01_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-aarch64::gensim-4.3.0-py38h19f5adf_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-aarch64::gensim-4.3.0-py38hfd9fcc1_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-aarch64::gensim-4.3.0-py39h1e1c27f_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-aarch64::gensim-4.3.0-py39h5ae63dd_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
Downloading: https://conda.anaconda.org/conda-forge/linux-ppc64le/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-ppc64le/repodata.json.bz2
linux-ppc64le::gensim-4.3.0-py310hc75b01a_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-ppc64le::gensim-4.3.0-py38h898da7e_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-ppc64le::gensim-4.3.0-py38hd4e458e_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-ppc64le::gensim-4.3.0-py39h3cc8c3b_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
linux-ppc64le::gensim-4.3.0-py39h903958b_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
Downloading: https://conda.anaconda.org/conda-forge/osx-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-64/repodata.json.bz2
osx-64::gensim-4.3.0-py310hecf8f37_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
osx-64::gensim-4.3.0-py38h057a07e_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
osx-64::gensim-4.3.0-py38hec72209_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
osx-64::gensim-4.3.0-py39hc68f3d3_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
osx-64::gensim-4.3.0-py39hecff1ad_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
Downloading: https://conda.anaconda.org/conda-forge/osx-arm64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-arm64/repodata.json.bz2
osx-arm64::gensim-4.3.0-py310h2b830bf_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
osx-arm64::gensim-4.3.0-py38h61dac83_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
osx-arm64::gensim-4.3.0-py39hde7b980_1.conda
-    "smart_open >=1.8.1"
+    "smart_open >=1.8.1",
+    "fuzzytm >= 0.4.0"
Downloading: https://conda.anaconda.org/conda-forge/win-32/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-32/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-64/repodata.json.bz2
win-64::gensim-4.3.0-py310h1c4a608_1.conda
-    "vs2015_runtime >=14.29.30139"
+    "vs2015_runtime >=14.29.30139",
+    "fuzzytm >= 0.4.0"
win-64::gensim-4.3.0-py38h5846ac1_1.conda
-    "vs2015_runtime >=14.29.30139"
+    "vs2015_runtime >=14.29.30139",
+    "fuzzytm >= 0.4.0"
win-64::gensim-4.3.0-py38hc701a83_1.conda
-    "vs2015_runtime >=14.29.30139"
+    "vs2015_runtime >=14.29.30139",
+    "fuzzytm >= 0.4.0"
win-64::gensim-4.3.0-py39h2ba5b7c_1.conda
-    "vs2015_runtime >=14.29.30139"
+    "vs2015_runtime >=14.29.30139",
+    "fuzzytm >= 0.4.0"
win-64::gensim-4.3.0-py39hfed2c35_1.conda
-    "vs2015_runtime >=14.29.30139"
+    "vs2015_runtime >=14.29.30139",
+    "fuzzytm >= 0.4.0"

[jaimergp]

Hi @PrimozGodec, can you share a link somewhere explaining the underlying issue for reference? Also, pinging @conda-forge/gensim for advice / awareness / approval.

[PrimozGodec]

Hi @PrimozGodec, can you share a link somewhere explaining the underlying issue for reference? Also, pinging @conda-forge/gensim for advice / awareness / approval.

Hi @jaimergp, I added the link to PR where I have problems with this missing package in the description conda-forge/orange3-text-feedstock#63.

[jaimergp]

For reference, this is the error we can see in that log:

pkg_resources.DistributionNotFound: The 'FuzzyTM>=0.4.0' distribution was not found and is required by gensim

But that's a bit weird, since gensim's upstream doesn't list it either 🤔

Looking at the PyPI tarball, in *.egg-info/requires.txt, we see:

numpy>=1.18.5
scipy>=1.7.0
smart_open>=1.8.1

[distributed]
Pyro4>=4.27

[docs]
pytest
pytest-cov
mock
cython
testfixtures
POT
Pyro4>=4.27
visdom!=0.1.8.7,>=0.1.8
sphinx==5.1.1
sphinx-gallery==0.11.1
sphinxcontrib.programoutput==0.17
sphinxcontrib-napoleon==0.7
matplotlib
memory_profiler
annoy
Pyro4
nltk
statsmodels
pandas

[test]
pytest

, so no fuzzytm there either.

It looks like a false positive or error in pkg_resources.require? You can probably add fuzzytm to your test.requires section in your meta.yaml to workaround this error, if you agree with my assessment above.

[jaimergp]

Ah wait, 4.3.0 did require it.

[jaimergp]

In that case, I'm ok. I'll just give @conda-forge/gensim a couple days so they can see this.

Thanks for reporting it!

[PrimozGodec]

@jaimergp, can it be merged? I think @conda-forge/gensim forgot to include this requirement since it was added by mistake to the package (and removed in a later release). Anyway, for 4.3.0 to be used, it must be in the requirements since it is in the PyPI release requirements.

This PR prevents me to proceed with conda-forge/orange3-text-feedstock#63

[isuruf]

Repodata patching should not add dependencies AFAIK. It should only change version constraints or add to run constrains.

[jaimergp]

Anyway, for 4.3.0 to be used, it must be in the requirements since it is in the PyPI release requirements.

If it was added by mistake (the PR that added the requirement does not import it at all), then I am inclined to leave it as is, and for your use case, add fuzzytm to test.requires temporarily since it's not actually needed anywhere; you just need to satisfy pip check.

[PrimozGodec]

@jaimergp, thank you for the suggestion. I didn't think about this solution before. I agree it is the best idea. I am closing this PR.