Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prompt-toolkit for ipython 8.18 #605

Merged
merged 1 commit into from Dec 4, 2023

Conversation

beenje
Copy link
Contributor

@beenje beenje commented Dec 4, 2023

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

ipython 8.18.0 requires prompt-toolkit >= 3.0.41 (ipython/ipython#14255).
It was fixed in ipython 8.18.1 (ipython/ipython#14257) but missed in conda-forge package.
Fixed in build 2 of the recipe: conda-forge/ipython-feedstock#204

$ python show_diff.py --subdirs noarch
================================================================================
================================================================================
noarch
noarch::ipython-8.18.0-pyh5737063_0.conda
noarch::ipython-8.18.0-pyh31c8845_0.conda
noarch::ipython-8.18.0-pyh0d859eb_0.conda
-    "prompt_toolkit >=3.0.30,<3.1.0,!=3.0.37",
+    "prompt-toolkit >=3.0.41,<3.1.0",
noarch::ipython-8.18.1-pyh31011fe_1.conda
noarch::ipython-8.18.1-pyh5737063_1.conda
-    "prompt-toolkit >=3.0.30,<3.1.0,!=3.0.37",
+    "prompt-toolkit >=3.0.41,<3.1.0",

ipython 8.18.0 requires prompt-toolkit >= 3.0.41 (ipython/ipython#14255).
It was fixed in ipython 8.18.1 (ipython/ipython#14257)
but missed in conda-forge package.
Fixed in build 2 of the recipe: conda-forge/ipython-feedstock#204
@beenje beenje requested a review from a team as a code owner December 4, 2023 15:45
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy merged commit b2e0795 into conda-forge:main Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants