Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin typeguard >=4.0.1's typing_extensions to 4.7.0 #615

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 8, 2023

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

References:

Changes:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
noarch
noarch::typeguard-4.1.1-pyhd8ed1ab_0.conda
noarch::typeguard-4.1.0-pyhd8ed1ab_0.conda
noarch::typeguard-4.1.3-pyhd8ed1ab_1.conda
noarch::typeguard-4.1.4-pyhd8ed1ab_0.conda
noarch::typeguard-4.1.3-pyhd8ed1ab_0.conda
noarch::typeguard-4.1.5-pyhd8ed1ab_0.conda
noarch::typeguard-4.0.1-pyhd8ed1ab_0.conda
noarch::typeguard-4.1.2-pyhd8ed1ab_0.conda
-    "typing_extensions >=4.4.0"
+    "typing_extensions >=4.7.0"
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

initially, was
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::joseki-2.2.0-pyhd8ed1ab_0.conda
-{
-  "build": "pyhd8ed1ab_0",
-  "build_number": 0,
-  "depends": [
-    "attrs >=22.2.0",
-    "click >=8.1.3",
-    "importlib-resources >=5.10.2",
-    "netcdf4 >=1.6.2",
-    "numpy >=1.22.0",
-    "pandas >=1.5.2",
-    "pint >=0.20.1",
-    "python >=3.8",
-    "scipy >=1.9.3",
-    "ussa1976 >=0.3.4",
-    "xarray >=2022.12.0"
-  ],
-  "license": "MIT",
-  "md5": "4c752308f6659dde7207e0be0dde9dec",
-  "name": "joseki",
-  "noarch": "python",
-  "sha256": "30ff7c41c6c600fce246d0913c237ae902797446d246ee4a829fb149f3f12efd",
-  "size": 84028,
-  "subdir": "noarch",
-  "timestamp": 1689670820578,
-  "version": "2.2.0"
-}
+{}
noarch::joseki-2.3.0-pyhd8ed1ab_0.conda
-{
-  "build": "pyhd8ed1ab_0",
-  "build_number": 0,
-  "depends": [
-    "attrs >=22.2.0",
-    "click >=8.1.3",
-    "importlib-resources >=5.10.2",
-    "netcdf4 >=1.6.2",
-    "numpy >=1.22.0",
-    "pandas >=1.5.2",
-    "pint >=0.20.1",
-    "python >=3.8",
-    "scipy >=1.9.3",
-    "ussa1976 >=0.3.4",
-    "xarray >=2022.12.0"
-  ],
-  "license": "MIT",
-  "md5": "f448ee458795eb74d8863d0f45344432",
-  "name": "joseki",
-  "noarch": "python",
-  "sha256": "92b9c7af9d7f08904c22641a37e091dae87ea8972598de7a4d80ff72c4ec2477",
-  "size": 85596,
-  "subdir": "noarch",
-  "timestamp": 1689863350112,
-  "version": "2.3.0"
-}
+{}
noarch::typeguard-4.1.5-pyhd8ed1ab_0.conda
-    "typing_extensions >=4.4.0"
+    "typing_extensions >=4.7.0"
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

@bollwyvl bollwyvl requested a review from a team as a code owner December 8, 2023 21:01
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@njzjz
Copy link
Member

njzjz commented Dec 8, 2023

Perhaps you can also patch 4.0.1~4.1.4. See agronholm/typeguard@686f25a

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 8, 2023

Need to step away, but happy for any further review.

@bollwyvl bollwyvl changed the title pin typeguard 4.1.5's typing_extensions to 4.7.0 pin typeguard >=4.0.1's typing_extensions to 4.7.0 Dec 8, 2023
@bollwyvl
Copy link
Contributor Author

@conda-forge/core still ready for review ❤️

@xhochy xhochy merged commit 0e3ce2f into conda-forge:main Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants