New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add missing packages to removals #718

Merged

github-actions merged 6 commits into conda-forge:main from beckermr:beckermr-patch-1

Apr 26, 2024

Member

beckermr commented Apr 26, 2024 •

edited

Loading

Checklist

Used a static YAML file for the patch if possible (instructions).
Only wrote code directly into generate_patch_json.py if absolutely necessary.
Ran pre-commit run -a and ensured all files pass the linting checks.
Ran python show_diff.py and posted the output as part of the PR.
Modifications won't affect packages built in the future.

This PR adds these missing packages to the removals so that we don't tell someone to try and download them.

xref: conda/infrastructure#892 (comment)


          ENH add missing packages to removals

3e73b0d

beckermr requested a review from a team as a code owner

April 26, 2024 19:12

Contributor

conda-forge-webservices bot commented Apr 26, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Member Author

beckermr commented Apr 26, 2024

pre-commit.ci autofix


          [pre-commit.ci] auto fixes from pre-commit.com hooks

9e2cd6d

for more information, see https://pre-commit.ci

jakirkham reviewed

View reviewed changes

Member

jakirkham left a comment

Thanks Matt! 🙏

Looks good

Should we add a comment about the reason for the removal? Also had one style suggestion below (Idk whether pre-commit will like it)

recipe/gen_patch_json.py Outdated Show resolved Hide resolved

beckermr commented

View reviewed changes

recipe/gen_patch_json.py Show resolved Hide resolved

beckermr commented

View reviewed changes

recipe/gen_patch_json.py Show resolved Hide resolved

beckermr commented

View reviewed changes

recipe/gen_patch_json.py Show resolved Hide resolved

beckermr commented

View reviewed changes

recipe/gen_patch_json.py Outdated Show resolved Hide resolved


          DOC add comments on removals

82ad10a

beckermr commented

View reviewed changes

recipe/gen_patch_json.py Outdated Show resolved Hide resolved


          BUG commented on wrong line

24ff948

Member Author

beckermr commented Apr 26, 2024

pre-commit.ci autofix

pre-commit-ci bot and others added 2 commits

April 26, 2024 19:39


          [pre-commit.ci] auto fixes from pre-commit.com hooks

527566a

for more information, see https://pre-commit.ci


          Use block comments for all failed uploads

565203a

Member

jakirkham commented Apr 26, 2024

Like the block comment idea that you used. Applied in the other cases

jakirkham approved these changes

View reviewed changes

jakirkham added the automerge label

Member

jakirkham commented Apr 26, 2024

Thanks Matt! 🙏

Let's get this in

github-actions bot merged commit 9133bc1 into conda-forge:main

4 checks passed

Contributor

github-actions bot commented Apr 26, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment