-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loosen zlib-pin to major level (1/N; May 2024) #739
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
If we restrict to a single month (though we'd have to do that several times obviously), we'd get down to about ~4500 artefacts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for going month by month. If this works well, we could likely construct a migration via the bot that would make these PRs automatically.
It's trivial to script the timestamp-logic, but I'm not sure it's worth setting up a separate migrator. I don't mind opening a few PRs, I mainly need to know what kind of cadence we want to aim for, how far back we want to go, and what the plan is for dealing with possible stragglers. But we can discuss that in conda-forge/conda-forge-pinning-feedstock#5959 |
FWIW, April has around 4000 artefacts that are affected |
We should let the CDN sync once or twice between PRs in terms of cadence. For this specific issue, even though I really don't like it, I think we should patch everything. :/ |
How often does the CDN sync happen? |
The CDN sync runs on a loop and the delay time between when a package uploads and is in the repodata is the sync time. |
So we should be able to do a month every ~4 hours? |
Sure yeah. |
Alright, let's get this effort started. Once we've patched the first 2-3 months of repodata, we should start seeing environments that only rely on recent builds to pull in zlib 1.3, so I'm planning to slow down a bit around there to see if we run into troubles, and then pick up speed if we don't see any issues occur. |
Restricted to monthly cadence after discussion in conda-forge/conda-forge-pinning-feedstock#5959
Previously: