Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make travis opt-in? #1875

Open
beckermr opened this issue Jan 10, 2023 · 19 comments
Open

make travis opt-in? #1875

beckermr opened this issue Jan 10, 2023 · 19 comments

Comments

@beckermr
Copy link
Member

We're having a lot of trouble with a token rotation right now (conda-forge/status#137) due to travis API rate limits. Some of this was a poorly coded bot on my part for sure. However, with cross-compilation working reasonably well these days, it could be argued that travis should be opt-in. We have other opt-in CI services coming up as well. So maybe now is the time to make this change and develop the infrastructure we'd need for it.

@beckermr
Copy link
Member Author

cc @conda-forge/core

@beckermr
Copy link
Member Author

cc @h-vetinari for viz

@beckermr
Copy link
Member Author

This could support the GPU ci opt-in as well. @jaimergp

@jaimergp
Copy link
Member

Yes, I have been thinking about this for Cirun.

We need a core-controlled list somewhere. It doesn't need to traverse the graph, so it can be controlled by admin-requests. For Cirun we have conda-forge/.cirun, maybe we can have conda-forge/.travis too? Or maybe we keep things in different repos.

@h-vetinari
Copy link
Member

cc @h-vetinari for viz

Thanks for the ping. We've gone back and forth on the default for aarch/ppc as I recall. For feedstocks that can run on azure (either in emulation or better cross-compilation), I tend to do that, because Travis is just too flaky for my taste, on top of very long queues.

So I know how to work around it in either case, but +1 to not use Travis by default

@leofang
Copy link
Member

leofang commented Jan 10, 2023

Travis is too flaky. Green in PRs does not guarantee green in the main branch. I'd argue we just remove Travis support... but if it's not an option, making it opt-in it is.

@beckermr
Copy link
Member Author

@jaimergp where is the list for cirun?

@jaimergp
Copy link
Member

We don't have any yet. We need a mechanism for this though, and I'd be happy to work on this as a general "get access to opt-in providers" task. The idea is tangentially based on how the PPC/ARM/ARM64 opt-ins have worked.

@jaimergp
Copy link
Member

Travis is the only (?) provider offering native ppc64le / aarch64, so it should be offered, but I'd argue it should only allow it as a last resort (if you can't support cross compiled builds).

@hmaarrfk
Copy link
Contributor

travis is useful to test failures due to qemu.

Typically, i find that 1 hour on travis = 6 hours on azure + qemu. So in terms of time "saved", there isn't much if you need "native or emulation".

It would be nice to have it enabled again, even if slowly.

@leofang
Copy link
Member

leofang commented Jan 10, 2023

It'd be nice to know why cross-compiling or qemu do not work. For me there's absolutely no saving to run on Travis -- it's simply an illusion that something passes and gets merged, and hours later I come back and discover that it fails for no reason on main, and spend another 12 hours (yes, I agree on the 6x slowdown, and it's 12 because of PR & main runs) to get the deployment done through azure + qemu.

I am not against making it opt-in. But if abandoning Travis is an option, the discussion to make it opt-in would be moot.

@beckermr
Copy link
Member Author

We cannot remove or deprecate travis right now for the record.

@jaimergp
Copy link
Member

@beckermr, do we need a CFEP for this general sort of "opt-in CI providers" functionality we are discussing?

@beckermr
Copy link
Member Author

beckermr commented Jan 10, 2023

It's right on the threshold for sure. We removed circle and drone without a cfep but the infrastructure here is bigger. The security and systems subteam also has some purview here potentially and that activity needs to advise and work with core but no cfep.

@h-vetinari
Copy link
Member

h-vetinari commented Feb 1, 2023

Just saw the following banner on a travis build:

Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance or alter your Consume paid credits for OSS setting.

@jaimergp
Copy link
Member

We have been granted a NumFocus SDG to work on opt-in CI features in conda-forge, so hopefully we can make this work soon!

@jaimergp
Copy link
Member

jaimergp commented Dec 4, 2023

With the recent work in admin-requests (thanks @aktech, @isuruf!), we can finally proceed with this. IOW, disable Travis by default for new feedstocks, and document how users can request access for non x64 archs.

WDYT @conda-forge/core?

@beckermr
Copy link
Member Author

beckermr commented Dec 4, 2023

I'd say LGTM.

@jakirkham
Copy link
Member

...document how users can request access for non x64 archs

Has this already been done somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants