-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_exports
in MPI example
#2039
Comments
I think the text above the quoted example should help clarify the intent here? conda-forge.github.io/src/maintainer/knowledge_base.rst Lines 734 to 750 in abb0e2e
|
No, it doesn't clarify why the |
I think the text here can be improved. My interpretation of this sentence
is that an MPI-consuming package, referred to as X whose recipe is in discussion, can choose to not export itself, assuming it is quite stable across versions such that downstream packages of X do not care. At run time, any of the X's variants (nompi, mpich, openmpi, ...) can be used. This could make the downstreams' lives simpler because they just need to build against the nompi variant, avoiding bifurcation of CI pipelines. However, obviously the stableness assumption is case by case, and arguably quite strong for most cases. In practice, we usually add I don't have good suggestions for better wording, as I imagine any new change would start overlapping with other sections and also make this already-long section even longer 😅 |
Where should the content be changed?
https://conda-forge.org/docs/maintainer/knowledge_base.html#complete-example
What should be changed?
conda-forge.github.io/src/maintainer/knowledge_base.rst
Lines 803 to 806 in abb0e2e
I am wondering why there is no package exported for the
nompi
package.I think it should be corrected to
Or, if the package should not be exported,
run_constrained
should be used instead ofrun_exports
:Additional information
Originally submitted in conda-forge/plumed-feedstock#36, but I noticed it just copies the documentation.
Incorrect or outdated
The text was updated successfully, but these errors were encountered: