Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status page: query params instead of pretty URLs? #2132

Open
Tracked by #2137
jaimergp opened this issue Mar 26, 2024 · 3 comments
Open
Tracked by #2137

Status page: query params instead of pretty URLs? #2132

jaimergp opened this issue Mar 26, 2024 · 3 comments
Labels
javascript Pull requests that update Javascript code

Comments

@jaimergp
Copy link
Member

@afshin was mentioning (please, extend this as necessary) that technically speaking, we shouldn't be using pretty URLs (/status/migration/name) for the migration details page, but instead query params (/status/?migration=name).

This would prevent the "404 flash" and would better comply with the "contract of page permanence".

@jaimergp jaimergp added the javascript Pull requests that update Javascript code label Mar 26, 2024
@afshin
Copy link
Member

afshin commented Mar 26, 2024

I think it would most likely look like /status/migration?name={name}, but yes, otherwise exactly as Jaime says!

@jaimergp
Copy link
Member Author

While we are at it, could we also add a view={table,graph} param?

@afshin
Copy link
Member

afshin commented Mar 26, 2024

That is also pretty straightforward and sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Development

No branches or pull requests

2 participants