Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning gobject-introspection? #436

Closed
jakirkham opened this issue Sep 7, 2017 · 5 comments
Closed

Pinning gobject-introspection? #436

jakirkham opened this issue Sep 7, 2017 · 5 comments

Comments

@jakirkham
Copy link
Member

Seems we are pinning gobject-introspection in some cases and not others. Should it be pinned? If so to what? FWIW here is the ABI report.
@jakirkham
Copy link
Member Author

cc @ocefpaf @pkgw @ccordoba12

@jakirkham jakirkham changed the title Pinning gobject-introspection Pinning gobject-introspection? Sep 7, 2017
@pkgw
Copy link
Contributor

pkgw commented Sep 8, 2017

Looks like the ABI has been quite stable, which I think is something we can expect going forward since the GLib/Gtk+ folks are generally pretty careful about that stuff. In my personal packages I generally pin things "just in case" but if that adds to hassles on the conda-forge end, I don't think pinning is actually necessary.

@jakirkham
Copy link
Member Author

Maybe just require 1.45.3 or greater as that is the last time a symbol was added?

@pkgw
Copy link
Contributor

pkgw commented Jan 2, 2018

Sure, that seems like a fine policy.

@jakirkham jakirkham mentioned this issue Feb 28, 2018
Open
@jakirkham
Copy link
Member Author

Issue moved to conda-forge/conda-forge-pinning-feedstock #9 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkgw @jakirkham