Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin libedit #478

Closed
djsutherland opened this issue Nov 2, 2017 · 8 comments
Closed

pin libedit #478

djsutherland opened this issue Nov 2, 2017 · 8 comments

Comments

@djsutherland
Copy link
Contributor

djsutherland commented Nov 2, 2017

libedit should be pinned to something. But I'm not totally sure what: it seems that our libedit package is editline from http://thrysoee.dk/editline/, currently at version 3.1; the tracker entry for editline is for https://github.com/troglobit/editline/ (source), currently at version 1.15.2. I don't know what the relationship is between those two projects with the same name.

cc @conda-forge/libedit

@jakirkham
Copy link
Member

Do you mind following up with the LVC team? Here is their package issue tracker.

@djsutherland
Copy link
Contributor Author

Yep, it seems that the packages are actually just independent despite having the same name. lvc/upstream-tracker#21

@djsutherland
Copy link
Contributor Author

Looks like it's slightly complicated: https://abi-laboratory.pro/tracker/timeline/libedit/

That is, there are multiple 3.1 versions, tagged with dates. I guess maybe we should change the libedit recipe to add the date as a minor version?

@jakirkham
Copy link
Member

Agreed. Looks like the date is part of the libedit version for better or worse.

cc @conda-forge/libedit @mingwandroid

@djsutherland
Copy link
Contributor Author

I just merged a new mysql recipe with a build dependency of libedit 3.1.20170329 and run of libedit >=3.1.20170329, since it seems to be persistently backwards compatible even from 3.0 to 3.1. I know pin_the_slow_way doesn't support that yet, but... 🤷‍♀️.

@jakirkham
Copy link
Member

Maybe just encourage exact pinning for now? I don't think we are planning to do much with libedit yet.

@mingwandroid
Copy link

mingwandroid commented Nov 13, 2017

Maybe just encourage exact pinning for now.

Why? https://abi-laboratory.pro/tracker/timeline/libedit

I am planning to do a lot with libedit and so would appreciate standardisation and as loose a pinning as strictly necessary here (and since its inception or at least as far back as abi-laboratory has tracked it, libedit has retained a 100% backwards compat. record).

@jakirkham
Copy link
Member

Issue moved to conda-forge/conda-forge-pinning-feedstock #10 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants