Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: ideas from recent submission #184

Closed
6 tasks
jankatins opened this issue May 24, 2016 · 2 comments
Closed
6 tasks

Lint: ideas from recent submission #184

jankatins opened this issue May 24, 2016 · 2 comments
Labels

Comments

@jankatins
Copy link
Contributor

jankatins commented May 24, 2016

These probably come from using a conda skeleton pypi ...

  • if the URL contains a long link to the pypi location, ask it to be changed to https://pypi.io/packages/source/<first letter of package>/<package>/<filename>
  • If it contains a git link and a tag (instead of a commit ID), tell it to include a real commit id instead of a tag
  • if bld.bat or build.sh is just python setup.py install (or the setuptools variant) suggest removing this and adding the line to the meta.yml
  • if recipe contains an install dependency on setuptools, check that the python call uses --single-version-externally-managed --record=record.txt
  • check for the version declaration at the top of the file and that it is used in all lines whichuse a version (filename, URL, version)
  • check for some licenses: BSD/BSD license -> BSD 3-clause and Python -> PSF -- see issue ( Check the license string #88 )
  • if it contains # List any patch files here or # noarch_python: True suggest removing these skeleton remnants
@jakirkham
Copy link
Member

Have changed these to checklist items so it is easier to track progress. Also the license check is already another issue, so noted that next to that line.

@jakirkham
Copy link
Member

If it contains a git link and a tag (instead of a commit ID), tell it to include a real commit id instead of a tag

Should add that I'm not sure how I feel about this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants