Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is BINSTAR_TOKEN handled differently than all other token? #50

Closed
jankatins opened this issue Feb 2, 2016 · 3 comments
Closed

Why is BINSTAR_TOKEN handled differently than all other token? #50

jankatins opened this issue Feb 2, 2016 · 3 comments

Comments

@jankatins
Copy link
Contributor

I'm currently trying to build a multiple recipe version of conda-smithy and found that all access token go into a subdir of ~, but only the BINSTAR_TOKEN is requested to be in os.environ. Is it ok, to change that to also use a file based access token ( ~\.conda-smithy\anaconda.token)?

@pelson
Copy link
Member

pelson commented Feb 10, 2016

Is it ok, to change that to also use a file based access token ( ~.conda-smithy\anaconda.token)?

Sure. Makes sense to me 👍

@pelson
Copy link
Member

pelson commented Mar 22, 2016

This was done. Thanks @JanSchulz

@pelson pelson closed this as completed Mar 22, 2016
@jankatins
Copy link
Contributor Author

jankatins commented May 23, 2016

Seems this commit was not applied: the binstar token is still gotten from the environment and not from anaconda.token https://github.com/conda-forge/conda-smithy/blob/master/conda_smithy/ci_register.py#L36

Commits are here: jankatins@8f73d00 and maybe 36dfa1a

Should I port these commits to the current codebase? The first commit is now in #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants