-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-forge.yml matrix ignored on rerender? #700
Comments
Add a
and you can use conda-forge.yml's matrix is removed now. (We should warn that it is removed though) |
Did this go in the wiki too? |
Great, thanks. |
Perfect, thanks. Manual step is AOK; a message about what I needed to do on rerender would be great (just a link to that wiki page would have been enough for me). |
Thanks @minrk. Appreciate your help testing. Think we will move the wiki content to the docs once we get closer. We can certainly add a warning (maybe even error?) when the old cba matrix feature appears. |
An error like "Can't rerender until you migrate conda-forge.yml matrix to conda_build_config.yml" sounds like a good idea to me, since the rerender result will always be wrong and need to be redone anyway. |
Can you send a PR? You can check for |
Sure, I'll give it a go. |
I'm trying to test rerendering with conda-smithy master and it's failing in a few cases. The first example I tried was https://github.com/conda-forge/mpi-feedstock which is an empty metapackage with two MPI_VARIANT matrix entries in conda-forge.yml. When I rerendered, I got only a single
config_.yml
without the MPI_VARIANTs.Is this a bug in rerender or is there an extra step I'm missing to migrate conda-forge.yml matrix entries to conda_build_config.yml?
The text was updated successfully, but these errors were encountered: