Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge.yml matrix ignored on rerender? #700

Closed
minrk opened this issue Mar 4, 2018 · 10 comments · Fixed by #702
Closed

conda-forge.yml matrix ignored on rerender? #700

minrk opened this issue Mar 4, 2018 · 10 comments · Fixed by #702

Comments

@minrk
Copy link
Member

minrk commented Mar 4, 2018

I'm trying to test rerendering with conda-smithy master and it's failing in a few cases. The first example I tried was https://github.com/conda-forge/mpi-feedstock which is an empty metapackage with two MPI_VARIANT matrix entries in conda-forge.yml. When I rerendered, I got only a single config_.yml without the MPI_VARIANTs.

Is this a bug in rerender or is there an extra step I'm missing to migrate conda-forge.yml matrix entries to conda_build_config.yml?

@isuruf
Copy link
Member

isuruf commented Mar 4, 2018

Add a recipe/conda_build_config.yaml file with

mpi_impl:
  - mpich
  - openmpi

and you can use mpi_impl as a jinja variable in the meta.yaml.

conda-forge.yml's matrix is removed now. (We should warn that it is removed though)

@jakirkham
Copy link
Member

Did this go in the wiki too?

@isuruf
Copy link
Member

isuruf commented Mar 4, 2018

@jakirkham
Copy link
Member

Great, thanks.

@minrk
Copy link
Member Author

minrk commented Mar 4, 2018

Perfect, thanks. Manual step is AOK; a message about what I needed to do on rerender would be great (just a link to that wiki page would have been enough for me).

@jakirkham
Copy link
Member

Thanks @minrk. Appreciate your help testing.

Think we will move the wiki content to the docs once we get closer.

We can certainly add a warning (maybe even error?) when the old cba matrix feature appears.

@minrk
Copy link
Member Author

minrk commented Mar 4, 2018

An error like "Can't rerender until you migrate conda-forge.yml matrix to conda_build_config.yml" sounds like a good idea to me, since the rerender result will always be wrong and need to be redone anyway.

@isuruf
Copy link
Member

isuruf commented Mar 4, 2018

@minrk
Copy link
Member Author

minrk commented Mar 4, 2018

Sure, I'll give it a go.

@minrk
Copy link
Member Author

minrk commented Mar 4, 2018

#702

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants