Use shell quotes for the current platform on the commit hint after re-rendering #408
Conversation
|
The Travis failure seems to be the same as in #407: |
| print( | ||
| "You can commit the changes with:\n\n" | ||
| " git commit -m 'MNT: Re-rendered with conda-smithy %s'\n" % __version__ | ||
| " git commit -m {q}MNT: Re-rendered with conda-smithy {version}{q}\n" |
There was a problem hiding this comment.
Honestly I'd be ok just using " if that is better for Windows. Both should work fine on Unix as there is nothing fancy going on in the message.
There was a problem hiding this comment.
I know this was your contribution originally @minrk . Do you care if we just use " or was there some special reason for ' that is not coming to me now?
There was a problem hiding this comment.
I only used ' because the surrounding string is ", so I wouldn't have to escape. No deeper reason than that. Switching the inner and outer quotes should work fine, too, or escape the inner quotes.
There was a problem hiding this comment.
Thanks @jakirkham and @minrk for the feedback.
Updated.
There was a problem hiding this comment.
Cool, thanks for confirming.
I couldn't remember if we were concerned about shell substitution at one point or not. Certainly shouldn't be a concern for this string.
Using " instead of ' is the correct form under Windows and also works on other platforms
nicoddemus
force-pushed
the
fix-win-commit-message-hint
branch
from
cac5b70
to
36a9805
Compare
|
Toggling for CI. |
|
Thanks @nicoddemus and @minrk . |
As discussed in #407