Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check: package/name == recipe-dir #499

Closed
wants to merge 2 commits into from

Conversation

epruesse
Copy link
Member

@epruesse epruesse commented Apr 1, 2017

Checks for mismatching package/name: and recipe directory as has happened in conda-forge/staged-recipes#2592 (fixed by conda-forge/staged-recipes#2718).

Also requires package: section to be present in meta.yaml

Also requires package section to be present in meta.yaml
 - Add one for new package name = dir name lint
 - Fix the bug it caught...
 - Fix other tests by creating subdir 'test_package' in tempdir
@jakirkham
Copy link
Member

While I certainly appreciate your thought in effort in trying to fix this somehow, this isn't really an appropriate fix as all feedstocks call the recipe directory recipe. Not to mention this underlying issue is only really a problem at staged-recipes at a point where conda-smithy doesn't really play a role. There's already an issue tracking this problem. So am closing this out. Please see issue ( conda-forge/staged-recipes#1073 ) for details. Happy to point out a place to make an appropriate fix for the issue if you have time/interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants